Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/extensions/yfm/ImgSize/ImageWidget/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const addImageWidgetAction = 'addImageWidget';

export type ImageWidgetOptions = Pick<
ImageWidgetDescriptorOpts,
'needToSetDimensionsForUploadedImages'
'needToSetDimensionsForUploadedImages' | 'enableNewImageSizeCalculation'
> & {
imageUploadHandler?: FileUploadHandler;
};
Expand All @@ -18,6 +18,7 @@ export const ImageWidget: ExtensionAuto<ImageWidgetOptions> = (builder, opts) =>
addImageWidget(deps, {
uploadImages: opts.imageUploadHandler,
needToSetDimensionsForUploadedImages: opts.needToSetDimensionsForUploadedImages,
enableNewImageSizeCalculation: opts.enableNewImageSizeCalculation,
}),
);
};
Expand Down
9 changes: 9 additions & 0 deletions src/extensions/yfm/ImgSize/ImageWidget/widget.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,15 @@ export const removeWidget = removeDecoration;
export type ImageWidgetDescriptorOpts = {
needToSetDimensionsForUploadedImages: boolean;
uploadImages?: FileUploadHandler;
enableNewImageSizeCalculation?: boolean;
};

class ImageWidgetDescriptor extends ReactWidgetDescriptor {
private readonly domElem;
private readonly deps;
private readonly uploadImages;
private readonly needToSetDimensionsForUploadedImages: boolean;
private readonly enableNewImageSizeCalculation?: boolean;

private widgetHandler: ImageWidgetHandler | null = null;

Expand All @@ -41,6 +43,7 @@ class ImageWidgetDescriptor extends ReactWidgetDescriptor {
this.deps = deps;
this.uploadImages = opts.uploadImages;
this.needToSetDimensionsForUploadedImages = opts.needToSetDimensionsForUploadedImages;
this.enableNewImageSizeCalculation = opts.enableNewImageSizeCalculation;
}

getWidgetHandler(view: EditorView, getPos: () => number): ImageWidgetHandler {
Expand All @@ -52,6 +55,7 @@ class ImageWidgetDescriptor extends ReactWidgetDescriptor {
decoId: this.id,
uploadImages: this.uploadImages,
needToSetDimensionsForUploadedImages: this.needToSetDimensionsForUploadedImages,
enableNewImageSizeCalculation: this.enableNewImageSizeCalculation,
},
this.deps,
);
Expand Down Expand Up @@ -80,6 +84,7 @@ type ImageWidgetHandlerProps = {
getPos: () => number;
uploadImages?: FileUploadHandler;
needToSetDimensionsForUploadedImages: boolean;
enableNewImageSizeCalculation?: boolean;
};

class ImageWidgetHandler {
Expand All @@ -90,6 +95,7 @@ class ImageWidgetHandler {
private readonly uploadImages;
private readonly normalizeUrl;
private readonly needToSetDimensionsForUploadedImages: boolean;
private readonly enableNewImageSizeCalculation?: boolean;

private cancelled = false;

Expand All @@ -100,6 +106,7 @@ class ImageWidgetHandler {
getPos,
uploadImages,
needToSetDimensionsForUploadedImages,
enableNewImageSizeCalculation,
}: ImageWidgetHandlerProps,
deps: ExtensionDeps,
) {
Expand All @@ -109,6 +116,7 @@ class ImageWidgetHandler {
this.uploadImages = uploadImages;
this.normalizeUrl = normalizeUrlFactory(deps);
this.needToSetDimensionsForUploadedImages = needToSetDimensionsForUploadedImages;
this.enableNewImageSizeCalculation = enableNewImageSizeCalculation;
}

destruct() {
Expand Down Expand Up @@ -157,6 +165,7 @@ class ImageWidgetHandler {
const {view} = this;
new ImagesUploadProcess(view, files, this.uploadImages, this.getPos(), {
needDimensions: this.needToSetDimensionsForUploadedImages,
enableNewImageSizeCalculation: this.enableNewImageSizeCalculation,
}).run();
view.dispatch(removeWidget(view.state.tr, this.decoId));
view.focus();
Expand Down
1 change: 1 addition & 0 deletions src/extensions/yfm/ImgSize/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ export const ImgSize: ExtensionAuto<ImgSizeOptions> = (builder, opts) => {
builder.use(ImageWidget, {
imageUploadHandler: opts.imageUploadHandler,
needToSetDimensionsForUploadedImages: Boolean(opts.needToSetDimensionsForUploadedImages),
enableNewImageSizeCalculation: Boolean(opts.enableNewImageSizeCalculation),
});

if (opts.imageUploadHandler || opts.parseInsertedUrlAsImage) {
Expand Down
Loading