feat(ImgSize): added ability to render custom form in image widget #639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
d3m1d0v
force-pushed
the
d3m1d0v/custom-image-form
branch
2 times, most recently
from
520fc3c to
5390375
Compare
|
Hi @d3m1d0v, won't let me approve like you asked, but this is great. I just tried out the example in the playground, and its exactly what I was after. I will probably do what you said and merge it with the current one so that adding an image by link is still possible too. Thanks for doing this so quickly. |
d3m1d0v
force-pushed
the
d3m1d0v/custom-image-form
branch
from
5390375 to
b2cf4f4
Compare
|
Will that example and the source code stay there in the playground now so I can look back on it when I get to this in a week or so? @d3m1d0v |
Yes, entire code from current PR will be merged into |
makhnatkin
approved these changes
Feb 18, 2025
d3m1d0v
force-pushed
the
d3m1d0v/custom-image-form
branch
from
b2cf4f4 to
81326e7
Compare
d3m1d0v
force-pushed
the
d3m1d0v/custom-image-form
branch
from
81326e7 to
a9b2e9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See
Examples / Custom Image Widgetpage in storybookFor #624