feat: blog post header extra buttons #266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview is ready. |
Contributor
|
Playwright Test Component is ready. |
Contributor
Author
|
Do you think I could change test screenshots? https://storage.yandexcloud.net/playwright-reports/blog-constructor/pulls/266/index.html#?testId=5c8382d0e21e66a97f26-91eceb8d3ae5fa274d1f |
NikitaCG
requested changes
May 19, 2025
| icon: Icon, | ||
| text, | ||
| onClick, | ||
| render: renderChildren, |
Collaborator
There was a problem hiding this comment.
why don't we just keep only render? in it, the user will determine which icons are needed and from which side, etc.
src/components/PostInfo/PostInfo.tsx
Outdated
| analyticsEventsContainer, | ||
| }: PostInfoProps) => { | ||
| const {likes} = React.useContext(PostPageContext); | ||
| const {extraInfoButtons: extraButtons} = React.useContext(SettingsContext); |
Collaborator
There was a problem hiding this comment.
why the extra renaming? maybe we need to named it extraInfoItems
NikitaCG
requested changes
May 20, 2025
NikitaCG
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.