feat: save button a11y #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview is ready. |
NikitaCG
requested changes
Aug 2, 2024
| }} | ||
| data-qa={qa} | ||
| aria-pressed={hasUserLike} | ||
| aria-label={i18n(Keyset.Save)} |
Collaborator
There was a problem hiding this comment.
I think we need to use title in this attr
PahaN47
commented
Aug 5, 2024
| aria-label={i18n(Keyset.Save)} | ||
| aria-describedby={titleElementId} | ||
| aria-label={isNumericTitle ? i18n(Keyset.Save) : undefined} | ||
| aria-describedby={isNumericTitle ? titleElementId : undefined} |
Contributor
Author
There was a problem hiding this comment.
Explanation: there is no need to add a label if title is text. At the same time when title is a number it is not very clear what the button does, so we add aria-label
NikitaCG
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.