Skip to content

Fix: Mask email_sender_password and okta_api_token#3991

Open
VishalDalwadi wants to merge 1 commit intorelease-v1.5.1from
fix/vulnerabilities
Open

Fix: Mask email_sender_password and okta_api_token#3991
VishalDalwadi wants to merge 1 commit intorelease-v1.5.1from
fix/vulnerabilities

Conversation

@VishalDalwadi
Copy link
Copy Markdown
Collaborator

Describe your changes

Provide Issue ticket number if applicable/not in title

Provide testing steps

Checklist before requesting a review

  • My changes affect only 10 files or less.
  • I have performed a self-review of my code and tested it.
  • If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
  • If it is a bugfix, my code is <= 200 lines.
  • My functions are <= 80 lines.
  • I have had my code reviewed by a peer.
  • My unit tests pass locally.
  • Netmaker is awesome.

@tenki-reviewer
Copy link
Copy Markdown
Contributor

tenki-reviewer Bot commented Apr 29, 2026

Tenki Code Review - Complete

Files Reviewed: 1
Findings: 0


The PR correctly adds masking for EmailSenderPassword and OktaAPIToken in the GET settings response, but introduces a critical bug: UpsertServerSettings does not restore these fields when the mask placeholder is received on a subsequent PUT, which will permanently overwrite the real credentials in the database.

Files Reviewed (1 files)
controllers/server.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant