Skip to content

Conversation

@tanyaarora-003
Copy link
Contributor

@tanyaarora-003 tanyaarora-003 commented Aug 22, 2025

Issue

https://gravitee.atlassian.net/browse/APIM-10754

Description

Eliminated duplicate entries in organization search users results.

Additional context

Before fix:

APIM-10754_before.mov

After fix:

APIM-10754_after.mov

📚  View the storybook of this branch here

@tanyaarora-003 tanyaarora-003 requested a review from a team as a code owner August 22, 2025 10:01
@tanyaarora-003 tanyaarora-003 force-pushed the APIM-10754-Duplicate-User-Entries-Appearing-Randomly-in-Search-Results branch from f9c8981 to d91cc47 Compare August 22, 2025 10:25
@NicolasGeraud
Copy link
Member

@tanyaarora-003 @Okhelifi Should we not also add a default sort in the mAPI, for those who use it?

@tanyaarora-003 tanyaarora-003 force-pushed the APIM-10754-Duplicate-User-Entries-Appearing-Randomly-in-Search-Results branch from 8c94cf2 to e3c2c2a Compare September 4, 2025 04:28
Copy link
Member

@Okhelifi Okhelifi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small feedback on the code readability. Otherwise it's ok for me

@tanyaarora-003 tanyaarora-003 force-pushed the APIM-10754-Duplicate-User-Entries-Appearing-Randomly-in-Search-Results branch from e3c2c2a to 212441e Compare September 8, 2025 06:56
@tanyaarora-003
Copy link
Contributor Author

@tanyaarora-003 @Okhelifi Should we not also add a default sort in the mAPI, for those who use it?

@NicolasGeraud That's a good suggestion. We can do default sort based on firstName, LastName(recommended) or on emails or source(how the user was created). WDYT?

@tanyaarora-003 tanyaarora-003 force-pushed the APIM-10754-Duplicate-User-Entries-Appearing-Randomly-in-Search-Results branch 2 times, most recently from 800d930 to aa9ab6d Compare September 8, 2025 11:25
@tanyaarora-003 tanyaarora-003 force-pushed the APIM-10754-Duplicate-User-Entries-Appearing-Randomly-in-Search-Results branch from aa9ab6d to 3522523 Compare September 8, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants