-
Notifications
You must be signed in to change notification settings - Fork 96
fix(console): eliminate duplicate entries in organization search users results #12945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(console): eliminate duplicate entries in organization search users results #12945
Conversation
f9c8981 to
d91cc47
Compare
...itee-apim-console-webui/src/organization/configuration/users/org-settings-users.component.ts
Outdated
Show resolved
Hide resolved
|
@tanyaarora-003 @Okhelifi Should we not also add a default sort in the mAPI, for those who use it? |
8c94cf2 to
e3c2c2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small feedback on the code readability. Otherwise it's ok for me
...e-apim-rest-api-service/src/main/java/io/gravitee/rest/api/service/impl/UserServiceImpl.java
Show resolved
Hide resolved
...e-apim-rest-api-service/src/main/java/io/gravitee/rest/api/service/impl/UserServiceImpl.java
Show resolved
Hide resolved
e3c2c2a to
212441e
Compare
@NicolasGeraud That's a good suggestion. We can do default sort based on firstName, LastName(recommended) or on emails or source(how the user was created). WDYT? |
800d930 to
aa9ab6d
Compare
aa9ab6d to
3522523
Compare
Issue
https://gravitee.atlassian.net/browse/APIM-10754
Description
Eliminated duplicate entries in organization search users results.
Additional context
Before fix:
APIM-10754_before.mov
After fix:
APIM-10754_after.mov
📚 View the storybook of this branch here