[v17] keystore: add support for custom kms tags (#48132) #48771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* keystore: add support for custom kms tags * remove utils.IsEmpty and use pointer for aws kms config * test tags len Co-authored-by: Nic Klaassen <nic@goteleport.com> * add yaml struct tags Co-authored-by: Nic Klaassen <nic@goteleport.com> * Update lib/auth/keystore/aws_kms_test.go Co-authored-by: Nic Klaassen <nic@goteleport.com> * keep TeleportCluster tag if not specified * add delete used key test cases with tagging * fix unit tests * remove unused tag var * Update lib/auth/keystore/aws_kms.go Co-authored-by: Nic Klaassen <nic@goteleport.com> --------- Co-authored-by: Nic Klaassen <nic@goteleport.com>
tigrato
approved these changes
Nov 12, 2024
nklaassen
approved these changes
Nov 12, 2024
dboslee
added
the
no-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backports #48132 to v17