NodeJoin Script: improve clean up message when using package manager #48743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When re-running the node join script, the script refused to continue because it detected teleport already on the system. The script had a couple of instructions that removed teleport from the system. One of the steps is the removal of the teleport binary. However, it would recommend the removal of the binaries even for systems that had package managers. This fails because, even if the binaries (teleport, tsh, tctl) are removed, the package manager will still refuse to install teleport again because it was not removed from the package manager database. This PR changes the script, so that if it detects a package manager, it will instead ask the user to remove the teleport package and not directly removing the binaries.
marcoandredinis
added
support-load
GavinFrazar
approved these changes
Nov 12, 2024
tigrato
approved these changes
Nov 13, 2024
public-teleport-github-review-bot
bot
removed the request for review
from strideynet
marcoandredinis
added
no-changelog
|
@marcoandredinis See the table below for backport results.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When re-running the node join script, the script refused to continue because it detected teleport already on the system. The script had a couple of instructions that removed teleport from the system.
One of the steps is the removal of the teleport binary. However, it would recommend the removal of the binaries even for systems that had package managers. This fails because, even if the binaries (teleport, tsh, tctl) are removed, the package manager will still refuse to install teleport again because it was not removed from the package manager database.
This PR changes the script, so that if it detects a package manager, it will instead ask the user to remove the teleport package and not directly removing the binaries.
Demo:
