-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "tsh app login" prompting for user login when multiple AWS roles are present #48716
Merged
greedy52
merged 3 commits into
master
from
STeve/48715_fix_tsh_app_login_multi_identity
Nov 14, 2024
Merged
Fix "tsh app login" prompting for user login when multiple AWS roles are present #48716
greedy52
merged 3 commits into
master
from
STeve/48715_fix_tsh_app_login_multi_identity
Nov 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/sm
tsh
tsh - Teleport's command line tool for logging into nodes running Teleport.
labels
Nov 8, 2024
greedy52
commented
Nov 8, 2024
This pull request is automatically being deployed by Amplify Hosting (learn more). |
codingllama
reviewed
Nov 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
codingllama
approved these changes
Nov 11, 2024
gabrielcorado
approved these changes
Nov 14, 2024
capnspacehook
approved these changes
Nov 14, 2024
public-teleport-github-review-bot
bot
removed the request for review
from rosstimothy
November 14, 2024 16:09
This was referenced Nov 14, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/branch/v16
backport/branch/v17
size/sm
tsh
tsh - Teleport's command line tool for logging into nodes running Teleport.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: Fix "tsh app login" prompting for user login when multiple AWS roles are present
Fixes #48715
tsh apps login
prompt for relogin when multiple cloud identities are available #48715Thanks @codingllama for suggesting the non-retryable error check.