Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "tsh app login" prompting for user login when multiple AWS roles are present #48716

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

greedy52
Copy link
Contributor

@greedy52 greedy52 commented Nov 8, 2024

changelog: Fix "tsh app login" prompting for user login when multiple AWS roles are present

Fixes #48715

Thanks @codingllama for suggesting the non-retryable error check.

@greedy52 greedy52 self-assigned this Nov 8, 2024
@github-actions github-actions bot added size/sm tsh tsh - Teleport's command line tool for logging into nodes running Teleport. labels Nov 8, 2024
lib/client/api.go Outdated Show resolved Hide resolved
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-48716.d3pp5qlev8mo18.amplifyapp.com

Copy link
Contributor

@codingllama codingllama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

lib/client/api.go Outdated Show resolved Hide resolved
lib/client/api.go Outdated Show resolved Hide resolved
lib/client/api.go Outdated Show resolved Hide resolved
lib/client/api.go Outdated Show resolved Hide resolved
lib/client/api_test.go Outdated Show resolved Hide resolved
lib/client/api_test.go Outdated Show resolved Hide resolved
lib/client/api.go Show resolved Hide resolved
@greedy52 greedy52 added this pull request to the merge queue Nov 14, 2024
Merged via the queue into master with commit 7f15309 Nov 14, 2024
40 checks passed
@greedy52 greedy52 deleted the STeve/48715_fix_tsh_app_login_multi_identity branch November 14, 2024 17:06
@public-teleport-github-review-bot

@greedy52 See the table below for backport results.

Branch Result
branch/v16 Create PR
branch/v17 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v16 backport/branch/v17 size/sm tsh tsh - Teleport's command line tool for logging into nodes running Teleport.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tsh apps login prompt for relogin when multiple cloud identities are available
4 participants