Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect postgres retention_period param #46898

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

programmerq
Copy link
Contributor

When trying to use retention_period with a postgresql:// URI, this causes a failure.

server error (FATAL: unrecognized configuration parameter "retention_period" (SQLSTATE 42704))

When trying to use `retention_period` with a `postgresql://` URI, this causes a failure.

`server error (FATAL: unrecognized configuration parameter "retention_period" (SQLSTATE 42704))`
Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

Copy link

🤖 Vercel preview here: https://docs-mseanxt31-goteleport.vercel.app/docs/ver/preview

@rosstimothy rosstimothy changed the title Remove incorrest postgres retention_period param Remove incorrect postgres retention_period param Sep 26, 2024
Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@zmb3 zmb3 requested a review from espadolini October 1, 2024 19:31
Comment on lines 60 to 61
# Firestore: firestore://events_table_name?eventRetentionPeriod=10d
# Postgres: postgresql://user_name@database-address/teleport_audit?retention_period=10d
retention_period: 365d
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correct syntax for pgevents would be something like postgresql://user_name@database-address/teleport_audit#retention_period=240h as mentioned in https://goteleport.com/docs/reference/backends/#postgresql , I don't know if we should mention that here or not.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@programmerq Does postgresql://user_name@database-address/teleport_audit#retention_period=240h work in your test environment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants