Migrate ReverseTunnel Resource APIs from HTTP to gRPC #46761
Conversation
strideynet
added
the
no-changelog
| DeleteReverseTunnel(ctx context.Context, tunnelName string) error | ||
| } | ||
|
|
||
| type Cache interface { |
There was a problem hiding this comment.
Should this include GetRemoteCluster and ListRemoteClusters as well 😬?
There was a problem hiding this comment.
Soo - when I converted RemoteClusters, I can recall that the GetRemoteClusters/GetRemoteCluster HTTP method called directly thru to the service rather than via the cache - and that this looked somewhat intentional (there was a method on auth.Server that just delegated the call to .Services). I was hesitant to change the behaviour to use the cache as part of the conversion.
More than happy to raise a PR to convert this to use the Cache if you feel that would be safe.
There was a problem hiding this comment.
Maybe add a comment indicating the two are explicitly meant to read from the backend then?
There was a problem hiding this comment.
Yeah - I had considered that but I wasn't really sure enough if it was intentional or not to codify it as intentional going forward and possibly dissuade someone from switching to the cache in future 😅
There was a problem hiding this comment.
@fspmarshall @espadolini any ideas or reasons for why remote clusters were always being read from the backend?
There was a problem hiding this comment.
I think it's for consistency when doing modifications but we should just not modify the RemoteCluster object just for advisory purposes IMO, it should be treated as a relatively high importance marker object.
I don't see a lot of functional drawbacks to using the cache, but I don't know if UX would be impacted by not having the cluster in the listings and the web UI immediately after adding a new leaf.
public-teleport-github-review-bot
bot
removed the request for review
from Joerger
Part of #6394
Creates gRPC equivelants for HTTP API methods related to the ReverseTunnel resource, and modifies the API client to try the new methods before falling back to the old methods.