Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit the "Connecting Apps" guide #46690

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Edit the "Connecting Apps" guide #46690

merged 1 commit into from
Oct 3, 2024

Conversation

ptgott
Copy link
Contributor

@ptgott ptgott commented Sep 17, 2024

Closes #12168

Edit the guide to enrolling web applications with a Teleport cluster to:

  • Abide by our conventions for the structure of a how-to guide, e.g., to include H2s that indicate step numbers.
  • Clarify some missing information from the original guide, such as where to start the Application Service as a service, how the Application Service and Proxy Service interact, and how labels work.

This change does not attempt to modify the conceptual information at the end of the guide aside from placing more of it under the "Advanced options" heading. This is because the product links to these sections in messages.

@ptgott ptgott added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v14 backport/branch/v15 backport/branch/v16 labels Sep 17, 2024
@github-actions github-actions bot requested a review from zmb3 September 17, 2024 20:00
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-lkigmsdl1-goteleport.vercel.app/docs/ver/preview

@ptgott ptgott mentioned this pull request Sep 19, 2024
Open
@ptgott ptgott force-pushed the paul.gottschling/12168-app-access branch from 496412b to 0986ca1 Compare September 20, 2024 20:08
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-bvu4hu3jv-goteleport.vercel.app/docs/ver/preview

@ptgott ptgott force-pushed the paul.gottschling/12168-app-access branch from 0986ca1 to e33a7fe Compare September 23, 2024 18:23
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-m6lwnpr1b-goteleport.vercel.app/docs/ver/preview

@ptgott ptgott force-pushed the paul.gottschling/12168-app-access branch from e33a7fe to 013780d Compare September 27, 2024 17:28
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-c9ikaq33p-goteleport.vercel.app/docs/ver/preview

@ptgott ptgott force-pushed the paul.gottschling/12168-app-access branch from 013780d to 57bd7db Compare September 30, 2024 13:21
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-duojvkes1-goteleport.vercel.app/docs/ver/preview

@ptgott
Copy link
Contributor Author

ptgott commented Sep 30, 2024

@mmcallister Checking to see if you have time to give this one a look. Thanks!

@ptgott ptgott enabled auto-merge October 2, 2024 14:08
@ptgott ptgott force-pushed the paul.gottschling/12168-app-access branch from 57bd7db to 53626c0 Compare October 2, 2024 14:08
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

🤖 Vercel preview here: https://docs-c2ee61yyz-goteleport.vercel.app/docs/ver/preview

@ptgott ptgott force-pushed the paul.gottschling/12168-app-access branch from 53626c0 to de54b0b Compare October 2, 2024 14:20
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

🤖 Vercel preview here: https://docs-ao2zq62e8-goteleport.vercel.app/docs/ver/preview

@ptgott ptgott force-pushed the paul.gottschling/12168-app-access branch from de54b0b to d88cfa1 Compare October 2, 2024 17:22
@ptgott ptgott force-pushed the paul.gottschling/12168-app-access branch from d88cfa1 to 27af748 Compare October 2, 2024 17:22
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

🤖 Vercel preview here: https://docs-fgbyjnwhq-goteleport.vercel.app/docs/ver/preview

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

🤖 Vercel preview here: https://docs-53n18i2kh-goteleport.vercel.app/docs/ver/preview

@ptgott ptgott force-pushed the paul.gottschling/12168-app-access branch from 27af748 to 9c5f8f0 Compare October 2, 2024 18:50
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

🤖 Vercel preview here: https://docs-5ozxvydhi-goteleport.vercel.app/docs/ver/preview

@ptgott
Edit the "Connecting Apps" guide
0f4b275 
Closes #12168

Edit the guide to enrolling web applications with a Teleport cluster to:
- Abide by our conventions for the structure of a how-to guide, e.g., to
  include H2s that indicate step numbers.
- Clarify some missing information from the original guide, such as
  where to start the Application Service as a service, how the
  Application Service and Proxy Service interact, and how labels work.

This change does not attempt to modify the conceptual information at the
end of the guide aside from placing more of it under the "Advanced
options" heading. This is because the product links to these sections in
messages.
@ptgott ptgott force-pushed the paul.gottschling/12168-app-access branch from 9c5f8f0 to 0f4b275 Compare October 3, 2024 21:37
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

🤖 Vercel preview here: https://docs-8ajl6bqrz-goteleport.vercel.app/docs/ver/preview

@ptgott ptgott added this pull request to the merge queue Oct 3, 2024
Merged via the queue into master with commit 4068722 Oct 3, 2024
40 checks passed
@ptgott ptgott deleted the paul.gottschling/12168-app-access branch October 3, 2024 22:05
@public-teleport-github-review-bot
Copy link

@ptgott See the table below for backport results.

Branch Result
branch/v14 Failed
branch/v15 Failed
branch/v16 Create PR

@ptgott ptgott mentioned this pull request Oct 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenGravy stevenGravy stevenGravy approved these changes

@mmcallister mmcallister mmcallister approved these changes

@r0mant r0mant Awaiting requested review from r0mant

@xinding33 xinding33 Awaiting requested review from xinding33

@zmb3 zmb3 Awaiting requested review from zmb3

Assignees
No one assigned
Labels
backport/branch/v14 backport/branch/v15 backport/branch/v16 documentation no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add more context/clarity to the Application Access "Connecting Apps" page
3 participants
@ptgott @mmcallister @stevenGravy