-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a firestore key migration to Teleport 17 #46472
Merged
Merged
Commits on Sep 11, 2024
-
Add a firestore key migration to Teleport 17
Throughout the lifespan of the Firestore backend, the type of the key parameter has evolved from `string`, to `[]byte`, to `backend.Key`, and eventually back to `[]byte`. With each new type, documents were added without migrating the existing ones. As a result, every time a new key type was introduced, an additional step was required during key iteration because Firestore maps each of these key types to a distinct database type. - `backend.Key` is mapped to an Array in Firestore. - `[]byte` is mapped to Bytes in Firestore. - `string` is mapped to a String in Firestore. When searching for a specific key, the Go type is converted into a proto type and encoded in a particular way. During the database's range query, all keys with a different type than the requested one are ignored. This allows us to retrieve only the relevant keys and convert them to `[]byte` by updating the database. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
Configuration menu - View commit details
-
Copy full SHA for 030072c - Browse repository at this point
Copy the full SHA 030072cView commit details -
Configuration menu - View commit details
-
Copy full SHA for a4e45a9 - Browse repository at this point
Copy the full SHA a4e45a9View commit details
Commits on Sep 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ac792a4 - Browse repository at this point
Copy the full SHA ac792a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 29d14b7 - Browse repository at this point
Copy the full SHA 29d14b7View commit details
Commits on Sep 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c2f93ec - Browse repository at this point
Copy the full SHA c2f93ecView commit details
Commits on Sep 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f74a94d - Browse repository at this point
Copy the full SHA f74a94dView commit details
Commits on Sep 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3fadc99 - Browse repository at this point
Copy the full SHA 3fadc99View commit details
Commits on Sep 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a26468f - Browse repository at this point
Copy the full SHA a26468fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1856068 - Browse repository at this point
Copy the full SHA 1856068View commit details -
Configuration menu - View commit details
-
Copy full SHA for 503efb4 - Browse repository at this point
Copy the full SHA 503efb4View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.