support split SSH/TLS keys in SSO login endpoints #45876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nklaassen
added
the
no-changelog
nklaassen
force-pushed
the
nklaassen/split-ssoLogin
branch
2 times, most recently
from
8306aae to
9f8d2b9
Compare
|
friendly ping @camscale @timothyb89 |
timothyb89
approved these changes
Aug 28, 2024
nklaassen
force-pushed
the
nklaassen/split-ssoLogin
branch
from
05c60bb to
75025a0
Compare
camscale
approved these changes
Aug 28, 2024
nklaassen
force-pushed
the
nklaassen/split-ssoLogin
branch
from
75025a0 to
76265d6
Compare
bl-nero
reviewed
Aug 29, 2024
nklaassen
force-pushed
the
nklaassen/split-ssoLogin
branch
from
581c36d to
cd74d63
Compare
Co-authored-by: Bartosz Leper <bartosz.leper@goteleport.com>
nklaassen
force-pushed
the
nklaassen/split-ssoLogin
branch
from
cd74d63 to
4c40ee2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for split SSH/TLS user keys to all SSO user login endpoints (including the teleport.e buddy PR for OIDC and SAML).
For each SSO auth method, the proxy basically
Create(Method)AuthRequesthttps://<proxy_addr>/(method)/requests/validateThere are a few different types in play to serialize the keys over gRPC and JSON, between client->proxy and client->auth. I have tested that login works with a v16 client connecting to a v16 proxy connected to an auth service on this branch, and it also works with all components on this branch.
Part of RFD 136