-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add backend Service and Cache support for SPIFFE Federation resource #45054
Changes from all commits
f62799f
d11924c
61db4eb
f126adb
7c8a4b8
49ab510
859e88c
718e533
43732f4
441c532
037fa63
826d8f3
3c4e0ee
651867f
a610cbb
e9b258d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -94,6 +94,7 @@ type Config struct { | |
SAMLIdPSession services.SAMLIdPSession | ||
SecReports services.SecReports | ||
SnowflakeSession services.SnowflakeSession | ||
SPIFFEFederations cache.SPIFFEFederationReader | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. any special reason to store the interface in the cache package There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's the cache's dependency. In this case, had I used I'd usually have this kind of interfaces unexported, but, there's a bit of a weird case here where the functionality in Largely, I'm trying to play with the idea that the I thought about having |
||
Trust services.Trust | ||
UserGroups services.UserGroups | ||
UserLoginStates services.UserLoginStates | ||
|
@@ -184,6 +185,7 @@ func NewCache(cfg Config) (*cache.Cache, error) { | |
SAMLIdPSession: cfg.SAMLIdPSession, | ||
SecReports: cfg.SecReports, | ||
SnowflakeSession: cfg.SnowflakeSession, | ||
SPIFFEFederations: cfg.SPIFFEFederations, | ||
Trust: cfg.Trust, | ||
UserGroups: cfg.UserGroups, | ||
UserLoginStates: cfg.UserLoginStates, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another go-jose version 😢