build: Ensure pinned versions when installing wasm-pack #37568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camscale
requested review from
klizhentas,
russjones,
r0mant,
zmb3,
fheinecke and
tcsc
as code owners
camscale
added
no-changelog
strideynet
approved these changes
Jan 30, 2024
ibeckermayer
approved these changes
Jan 30, 2024
public-teleport-github-review-bot
bot
removed request for
AntonAM and
rosstimothy
zmb3
approved these changes
Jan 30, 2024
AntonAM
approved these changes
Jan 30, 2024
tcsc
approved these changes
Jan 30, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
When installing `wasm-pack` with `cargo`, use the `--locked` flag to ensure the versions referenced in the Cargo.lock file are used and not any newer versions. This creates a repeatable build and insulates us from upstream breakage in new versions. In particular an upstream version change included the hoot-0.1.2 dependency on a new build which fails to build with rust 1.71.1, which is the version we are using. Link: rustwasm/wasm-pack#1365
camscale
force-pushed
the
camh/locked-cargo
branch
from
917b7d4 to
25517f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing
wasm-packwithcargo, use the--lockedflag toensure the versions referenced in the Cargo.lock file are used and not
any newer versions. This creates a repeatable build and insulates us
from upstream breakage in new versions.
Also pre-build
wasm-bindgen-clifirst with--lockedand tellwasm-packnot to install it, as when it installs it, it does not use
--lockedand we seethe same build failure there.
In particular an upstream version change included the hoot-0.1.2
dependency on a new build which fails to build with rust 1.71.1, which
is the version we are using.
Update e ref to get matching changes from teleport.e
Link: rustwasm/wasm-pack#1365