Add option to allow for host users not to be deleted #26892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lxea
force-pushed
the
lxea/perma-host-users
branch
from
f3fcffc to
e86423d
Compare
lxea
force-pushed
the
lxea/perma-host-users
branch
2 times, most recently
from
908e4cc to
19916ad
Compare
smallinsky
reviewed
May 30, 2023
lxea
force-pushed
the
lxea/perma-host-users
branch
from
19916ad to
dde1459
Compare
Theres an RFD update here with some information #27074 |
lxea
force-pushed
the
lxea/perma-host-users
branch
2 times, most recently
from
816e411 to
5897ffb
Compare
Joerger
reviewed
Jun 1, 2023
smallinsky
reviewed
Jun 5, 2023
lxea
force-pushed
the
lxea/perma-host-users
branch
13 times, most recently
from
8ef4c68 to
b620787
Compare
|
@Joerger @gabrielcorado @smallinsky Can you guys review this? |
smallinsky
approved these changes
Jun 21, 2023
lxea
force-pushed
the
lxea/perma-host-users
branch
3 times, most recently
from
32f61ba to
745ce36
Compare
Joerger
approved these changes
Jun 21, 2023
This adds a new role option called create_host_users_mode which allows for it to be configured to not delete users when a session ends. The old `create_host_user` option will be deprecated with this. If the deprecated option is set, the new mode option will default to dropping users as is the current behavior.
public-teleport-github-review-bot
bot
removed the request for review
from gabrielcorado
added 10 commits
June 22, 2023 12:30
lxea
force-pushed
the
lxea/perma-host-users
branch
from
bceb7ea to
6f604b2
Compare
This was referenced Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new role option called create_host_users_mode which allows for it to be configured to not delete users when a session ends. The old
create_host_useroption will be deprecated with this and if the create_host_user_mode option is set it'll always be preffered overcreate_host_user.If the deprecated option is set, the new mode option will default to dropping users as is the current behavior.