-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reproducible Teleport demo environments in Kubernetes #2585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial commit with split Helm chart for proxy/auth and node elements
…nd set exit on error
UnderGreen
approved these changes
Mar 3, 2019
examples/chart/teleport-demo/docker/cloudflare-agent/Dockerfile
Outdated
Show resolved
Hide resolved
examples/chart/teleport-demo/docker/teleport-ent/rootfs/scripts/teleport.sh
Outdated
Show resolved
Hide resolved
examples/chart/teleport-demo/docker/teleport-ent/rootfs/usr/bin/teleport-add-oidc
Outdated
Show resolved
Hide resolved
examples/chart/teleport-demo/docker/teleport-ent/rootfs/usr/bin/teleport-trustedcluster-join
Outdated
Show resolved
Hide resolved
Thanks for the review/feedback @UnderGreen! @eldios Don't mean to be a hassle but when you get a chance to look this over I'd appreciate it :) |
- Fix use of claims_to_roles so it can be specified in values.yaml - Improve Minikube/NodePort support - Replace use of containerPort with service port for LoadBalancer objects
…' and 'admin' roles in Teleport to split permissions
…teleport-demo-env
…ed permission scope
@UnderGreen @eldios Can you give this one last look over please before I merge? |
UnderGreen
approved these changes
Apr 3, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with some nitpicks
examples/chart/teleport-demo/docker/namespace-cleaner/Dockerfile
Outdated
Show resolved
Hide resolved
examples/chart/teleport-demo/docker/namespace-cleaner/rootfs/scripts/namespace-cleaner.sh
Show resolved
Hide resolved
…n tags for all containers now to keep things tidier
…teleport-demo-env
UnderGreen
reviewed
Apr 8, 2019
…ELEPORT_VERSION arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heavily modified the existing Helm charts in the Teleport repository to allow them to spin up bespoke multi-cluster Teleport demo environments
Requirements as described in https://github.com/gravitational/gravity.e/issues/3899
Reviewers as suggested by @klizhentas