Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move BPF event filtering to the kernel #23017

Merged
merged 3 commits into from
Mar 20, 2023
Merged

Conversation

jakule
Copy link
Contributor

@jakule jakule commented Mar 13, 2023

#19354 moved filtering of disk events to the kernel space. This PR continues work in this area and moves all events to be filtered in the kernel space.

@jakule jakule force-pushed the jakule/bpf-kernel-events branch from 987cc23 to 0abb3c1 Compare March 13, 2023 23:50
@jakule jakule marked this pull request as ready for review March 13, 2023 23:50
@github-actions github-actions bot added bpf Used to bugs with bpf and enhanced session recording. size/md labels Mar 13, 2023
@github-actions github-actions bot requested review from greedy52 and strideynet March 13, 2023 23:51
@jakule jakule force-pushed the jakule/bpf-kernel-events branch 2 times, most recently from d76de0e to 0cd7d57 Compare March 14, 2023 04:22
@jakule
Copy link
Contributor Author

jakule commented Mar 15, 2023

@strideynet @greedy52 Friendly ping.

Copy link
Contributor

@strideynet strideynet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't claim to be intimately familiar with eBPF, but, I'm pretty happy with this though.

// Check if the cgroup should be monitored.
is_monitored = bpf_map_lookup_elem(&monitored_cgroups, &cgroup);
if (is_monitored == NULL) {
// Missed entry.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Missed entry.
// cgroup has not been marked for monitoring, so ignore.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed in all places

jakule added 2 commits March 17, 2023 14:34
#19354 moved filtering of disk events to the kernel space. This PR continues work in this area and moves all events to be filtered in the kernel space.
Minor code fixes.
@jakule jakule force-pushed the jakule/bpf-kernel-events branch from 0cd7d57 to a5529d7 Compare March 17, 2023 19:23
@jakule jakule requested a review from greedy52 March 17, 2023 19:24
@jakule jakule added this pull request to the merge queue Mar 20, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 20, 2023
@jakule jakule added this pull request to the merge queue Mar 20, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 20, 2023
@jakule jakule added this pull request to the merge queue Mar 20, 2023
@jakule jakule merged commit 35a5688 into master Mar 20, 2023
@zmb3 zmb3 deleted the jakule/bpf-kernel-events branch May 7, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bpf Used to bugs with bpf and enhanced session recording. size/md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants