Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/events: remove no-op WaitForDelivery method #13217

Merged
merged 4 commits into from
Jun 6, 2022
Merged

lib/events: remove no-op WaitForDelivery method #13217

merged 4 commits into from
Jun 6, 2022

Conversation

zmb3
Copy link
Collaborator

@zmb3 zmb3 commented Jun 6, 2022

WaitForDelivery doesn't do anything and is never called, so get rid of it.

@github-actions github-actions bot requested review from atburke and codingllama June 6, 2022 19:24
@github-actions github-actions bot added the audit-log Issues related to Teleports Audit Log label Jun 6, 2022
@zmb3
Copy link
Collaborator Author

zmb3 commented Jun 6, 2022

The e counterpart is here: https://github.com/gravitational/teleport.e/pull/463

@codingllama
Copy link
Contributor

Thanks for cleaning up!

@zmb3 zmb3 enabled auto-merge (squash) June 6, 2022 20:38
@zmb3 zmb3 merged commit 4a12948 into master Jun 6, 2022
@zmb3 zmb3 deleted the zmb3/wait-for-delivery branch June 6, 2022 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codingllama codingllama codingllama approved these changes

@Joerger Joerger Joerger approved these changes

@atburke atburke Awaiting requested review from atburke

Assignees
No one assigned
Labels
audit-log Issues related to Teleports Audit Log
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zmb3 @codingllama @Joerger