Update backport bot to include original test plan in backports - #462
Open
rosstimothy wants to merge 1 commit into
Open
Update backport bot to include original test plan in backports#462rosstimothy wants to merge 1 commit into
rosstimothy wants to merge 1 commit into
Conversation
rosstimothy
marked this pull request as ready for review
March 9, 2026 18:53
hugoShaka
reviewed
Mar 9, 2026
| | Branch | Result | | ||
| |--------|--------| | ||
| | branch/v7 | [Create PR](https://github.com/foo/bar/compare/branch/v7...bot/backport-42-branch/v7?body=Backport+%2342+to+branch%2Fv7%0A%0Achangelog%3A+important+change%0A&expand=1&title=%5Bv7%5D+Best+PR) | | ||
| | branch/v7 | [Create PR](https://github.com/foo/bar/compare/branch/v7...bot/backport-42-branch/v7?body=Backport+%2342+to+branch%2Fv7%0A%0Achangelog%3A+important+change%0A&expand=1&labels=no-test-plan&title=%5Bv7%5D+Best+PR) | |
Contributor
There was a problem hiding this comment.
Is there a risk that we hit the URL max size?
Contributor
Author
There was a problem hiding this comment.
Possibly, though wasn't that already a risk of that if there was a long enough changelog?
Contributor
There was a problem hiding this comment.
Yes, it's just may more probable here as the test plan is typically longer than the 2 sentences we put in the changelog. My point is not to not do it, but we should put a threshold and drop the changelog if it's too large instead of failing the backport.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.