add ci-normalize tool - #439
Merged
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
Author
|
Example OSS run: https://github.com/gravitational/teleport/actions/runs/21073646763 |
rosstimothy
reviewed
Jan 20, 2026
Contributor
Author
|
OSS run with latest changes: https://github.com/gravitational/teleport/actions/runs/21214190170/job/61030541144 |
rosstimothy
reviewed
Jan 22, 2026
Comment on lines
+172
to
+176
| select { | ||
| case <-d.ctx.Done(): | ||
| return d.ctx.Err() | ||
| default: | ||
| } |
Contributor
There was a problem hiding this comment.
Should we teach sw.Write to respect contexts instead of checking once here?
Contributor
Author
There was a problem hiding this comment.
Internally it sw.Write checks the same context, this is just a escape hatch to error early if we already cancelled the context.
rosstimothy
reviewed
Jan 26, 2026
rosstimothy
left a comment
rosstimothy
left a comment
Contributor
There was a problem hiding this comment.
Looks better but it still feels overly abstracted in some places. I know that you were initially thinking to make this apply to junit files and benchmark tests which may be contributing to the abstractions and complexity. Can we pare this down a bit more?
rosstimothy
reviewed
Jan 27, 2026
Comment on lines
+25
to
+27
| errFn: func(tt require.TestingT, err error, i ...interface{}) { | ||
| assert.NoError(tt, err) | ||
| }, |
Contributor
There was a problem hiding this comment.
Did this get reverted?
rosstimothy
reviewed
Jan 27, 2026
rosstimothy
approved these changes
Jan 27, 2026
okraport
force-pushed
the
okraport/ci-normalize-tool-flat
branch
from
January 30, 2026 15:12
711ecab to
42380b9
Compare
Contributor
|
Could we please get a review from the @gravitational/cloud-team? |
evanfreed
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a MVP to get some metrics going into our results bucket, there is likely a lot of things that could be done tidier and will likely need more iteration in the future with expanded coverage.