Implement GPG providers (archive, key ID) - #420
Merged
Merged
Conversation
jimbishopp
reviewed
Nov 11, 2025
aadc-dev
reviewed
Nov 13, 2025
aadc-dev
reviewed
Nov 13, 2025
aadc-dev
reviewed
Nov 13, 2025
aadc-dev
reviewed
Nov 13, 2025
aadc-dev
reviewed
Nov 13, 2025
aadc-dev
approved these changes
Nov 13, 2025
aadc-dev
left a comment
aadc-dev
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just some nits around adding guard clauses / nil checks on params.
Contributor
Author
|
@aadc-dev left a couple of reply comments. Rather than repeat them on every comment block, I left them under a couple of specific questions to avoid rehashing identical issues repeatedly on the same PR. |
aadc-dev
approved these changes
Nov 14, 2025
jimbishopp
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds base64-encoded GPG archive and GPG key ID providers to OPRT2 based upon #400. This is to allow Attune to access the GPG signing keys for repo metadata signing.