Fix Vagrant #1840
Fix Vagrant #1840
Conversation
Since Unix line endings are enforced now, existing Windows contributors may have cloned the repo with autocrlf set to true and so Vagrant will not work properly. This warning message gives instructions on how to fix it. This also prevents confusing CRLF situations in the future. See - https://help.github.com/articles/dealing-with-line-endings - http://adaptivepatchwork.com/2012/03/01/mind-the-end-of-your-line/ - http://git-scm.com/docs/gitattributes
I had this separate because we were initially going to set the "trust" in pg_hba.conf, which requires knowledge of the version in the path.
|
Hey @joeyespo , this looks great. Are you ready for us to test? |
|
@clone1018 thanks! Yes, it finally builds all the way through! I'll update the README and help fix any environment-specific issues we see in another pull request. |
|
Why do you want to update the README in a different pull request? It seems like that should be part of this. |
|
@seanlinsley Really just to get .gitattributes in sooner than later so Windows users can test it without cloning this specific branch from my repo. I probably won't get around to documenting for a few days. |
|
I don't understand, how could someone possibly test your changes without cloning this branch locally? |
|
@seanlinsley If it's pulled in, you can simply This is functional though. I don't think the pull request should linger because of upcoming documentation. (The README is still valid as-is. I'm simply promoting Vagrant to be part of the Quick Start with a footnote/link to the common OS-specific problems.) |
|
Okay, that makes sense. I'll give this a try when I get off this train; Amtrak doesn't allow downloads of > 10 MB. |
|
:-) |
|
@seanlinsley Sounds like you're willing to look at this one? Let's not let perfect be the enemy of the good here. If this is a clear win over the status quo let's not hold it up unnecessarily. |
|
Let me know when it is pushed so I can get the latest vagrant files and let you know if it works well enough on Windows 8 or not :D |
|
@abnor give it a try! |
|
@abnor did you ever get Vagrant working? |
|
Sorry for dropping off the face of he earth. I've been using my energies to do adult people things and now I have free time again. Reenabling my virtualbox again as I had to shut it off for some installs. |
|
Hey all! Just letting you know that I opened a new issue, #1887, for further discussion of Vagrant issues. That way we don't pollute this pull request. |
|
Hey @joeyespo , is this where I pull the HTTPS clone? |
|
@abnor It's actually been merged in so you can grab the latest from Gittip: |
|
I keep getting fatal errors since it's not recognizing my git files. Will you be at the openhack tomorrow? I'll bring my computerbox and we can do this more quickly and with less me screwing things up. |
|
Interesting. Yeah I'll be there, let's figure this thing out. |
|
Yay~ |
No description provided.