Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

Replace distribute with setuptools (update dependencies) #2867

Closed
techtonik opened this issue Oct 30, 2014 · 7 comments
Closed

Replace distribute with setuptools (update dependencies) #2867

techtonik opened this issue Oct 30, 2014 · 7 comments
Assignees
@techtonik
Labels
TeamX ★

Comments

@techtonik
Copy link
Contributor

Distribute is merged into setuptools.

But more important - now older packages that come bundled with old distribute can not be installed.
https://bitbucket.org/pypa/setuptools/issue/18/packages-that-use_setuptools-from-older

This blocks #2327.
@clone1018 clone1018 mentioned this issue Oct 30, 2014
Closed
7 tasks
@techtonik
Copy link
Contributor Author

So far the only failing file was vendor/python-bitcoinaddress-0.2.2.tar.gz. Removing use_setuptools from it and deleting vendor/distribute-0.6.34.tar.gz fixed installation. Running tests right now.

I think that this library can be replaced with snippet from https://bitcointalk.org/index.php?topic=1026.0 which is also public domain and can be just dropped into Gratipay codebase.

techtonik added a commit to techtonik/gratipay.com that referenced this issue Nov 3, 2014
@techtonik
Bitcoin address check by Gavin Andresen, public domain
d87215d 
https://bitcointalk.org/index.php?topic=1026.0

This will remove dependency on python-bitcoinaddress-0.2.2.tar.gz
package that conflicts with recent setuptools (issue gratipay#2867)
techtonik added a commit to techtonik/gratipay.com that referenced this issue Nov 3, 2014
@techtonik
Remove vendor/bitcoinaddresses-0.2.2.tar.gz (issue gratipay#2867)
e5b30dc 
This should fail the tests to be fixed in subsequent commit
by switching to new utils/bitcoin.py
techtonik added a commit to techtonik/gratipay.com that referenced this issue Nov 3, 2014
@techtonik
Remove vendor/bitcoinaddresses-0.2.2.tar.gz (issue gratipay#2867)
7725146 
This should fail the tests to be fixed in subsequent commit
by switching to new utils/bitcoin.py
@galuszkak
Copy link
Contributor

Can be this done just by sending Pull Requests to bitcoinadress package? Seems maintainer is responsive and it's updating package...

@techtonik
Copy link
Contributor Author

Maintainer uses GPLed code from a bunch of sites, and I don't want to restrict myself to GPL, so I use public domain code, which is also a recommended way of validating addresses.

I also see no reason to use distribute for bitcoinaddress project (which basically caused this issue), so there is no ground to think that the code inside is maintained well. Anyway, I already added a bunch of features to the bitcoin.py including tests and command line interface that allows to extend it much faster in case we need to support validating of private keys or new address versions.

@galuszkak
Copy link
Contributor

As far I remember we choosen bitcoinaddress to not maintain that code on our side it was recommended by @zwn . Relevant #1814

@techtonik
Copy link
Contributor Author

Well, when you feel that this code should not belong, it is always possible to switch back to bitcoinaddress - API is compatible and tests cover everything. It is no problem for me to maintain this code, because it is more useful than the GPL version.

@techtonik
Copy link
Contributor Author

I also don't think that python-bitcoinaddress is better than the code that is recommended on Bitcoin wiki, and PyPI stats show that the library is not very popular. Maybe for a reason.

@techtonik techtonik mentioned this issue Nov 4, 2014
Closed
techtonik added a commit to techtonik/gratipay.com that referenced this issue Nov 5, 2014
@techtonik
Bitcoin address check by Gavin Andresen, public domain
aec0377 
https://bitcointalk.org/index.php?topic=1026.0

This will remove dependency on python-bitcoinaddress-0.2.2.tar.gz
package that conflicts with recent setuptools (issue gratipay#2867)
techtonik added a commit to techtonik/gratipay.com that referenced this issue Nov 5, 2014
@techtonik
Remove vendor/bitcoinaddresses-0.2.2.tar.gz (issue gratipay#2867)
45dfbcf 
This should fail the tests to be fixed in subsequent commit
by switching to new utils/bitcoin.py
chadwhitacre added a commit that referenced this issue Nov 6, 2014
@chadwhitacre
Merge pull request #2886 from techtonik/master
4865141 
Remove python-bitcoinaddress dependency p.2 (issue #2867)
@techtonik techtonik self-assigned this Nov 6, 2014
@techtonik techtonik mentioned this issue Nov 7, 2014
Merged
@techtonik
Copy link
Contributor Author

distribute is removed in 8f13d71.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@techtonik techtonik

Labels
TeamX ★
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@techtonik @galuszkak