Skip to content

Fix node data passed to treeViewNodeAdd #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2020
Merged

Fix node data passed to treeViewNodeAdd #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/TreeViewNode.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,7 +554,7 @@

if (childModel) {
this.model[this.childrenPropName].push(childModel);
this.$emit('treeViewNodeAdd', this.childModel, this.model, event);
this.$emit('treeViewNodeAdd', childModel, this.model, event);
}
}
},
Expand Down
8 changes: 8 additions & 0 deletions tests/unit/TreeViewNode.interactions.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,14 @@ describe('TreeViewNode.vue (interactions)', () => {
expect(wrapper.emitted().treeViewNodeAdd.length).to.equal(1);
});

it('should pass the new node data to the treeViewNodeAdd event', async () => {
addChildButton.trigger('click');

await Promise.resolve(); // This just lets the callback resolve before the expect.

expect(wrapper.emitted().treeViewNodeAdd[0][0].id).to.equal('newId');
});

it('should add a subnode to the target node from the model', async () => {
addChildButton.trigger('click');

Expand Down