Disallow non-breakable chains of circular references in Input Objects#701
Merged
leebyron merged 3 commits intographql:masterfrom Jan 11, 2021
spawnia:disallow-impossible-input-object-cycles
Merged
Disallow non-breakable chains of circular references in Input Objects#701leebyron merged 3 commits intographql:masterfrom spawnia:disallow-impossible-input-object-cycles
leebyron merged 3 commits intographql:masterfrom
spawnia:disallow-impossible-input-object-cycles
Conversation
Member
|
@spawnia No problem. Thanks for opening the new PR. |
Member
Member
Author
Pull Probot will just nuke my branch again when i do that. |
lirsacc
added a commit
to lirsacc/py-gql
that referenced
this pull request
Nov 1, 2020
This is based on a spec proposal (see: graphql/graphql-spec#701) and may change in the future.
|
Collaborator
|
@spawnia I'm in the process of finalizing editorial review before publishing the next spec edition and merging in accepted RFCs in the process. I'm merging this now, but if you wouldn't mind please verifying that you've signed the EasyCLA document above! |
Member
Author
|
@leebyron Thank you, i just signed. This must have been the third or fourth time i have had to do this - whatever it takes 🤷 |
Collaborator
|
I thought you might have already, you’ll notice it’s rejecting my commits as well, so I suspect this tool from LF is having a bad time. Thanks for the double/triple-check.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@leebyron I accidentally nuked the previous PR #445 by adding the Pull Probot, which hard-reset my
masterbranch. Sorry!