-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix: Leaf Field Selections for enums must also be empty #452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@MSleepyPanda Thanks for quick PR 👍 |
While i'm at it, re Example 114: I'd propose changing the name to |
@MSleepyPanda Good catch 👍
Makes total sense to me, but I suggest keeping |
spec/Section 5 -- Validation.md
Outdated
@@ -568,7 +568,7 @@ fragment conflictingDifferingResponses on Pet { | |||
|
|||
**Explanatory Text** | |||
|
|||
Field selections on scalars are never allowed: scalars | |||
Field selections on scalars or enums are never allowed: scalars and enums |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: maybe instead of : scalars and enums
write because they are the leaf nodes of any GraphQL query.
Great edit, thank you! |
No description provided.