Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formal spec of lone anonymous operation #156

Merged
merged 2 commits into from
Mar 22, 2016

Conversation

frankleonrose
Copy link
Contributor

Lone means lone. Set of ALL operations must be set of one.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@leebyron
Copy link
Collaborator

Thanks for highlighting this! I'm not sure your proposed change is correct though. It seems to read that only one operation of any kind may exist within a document, but this rule seeks to only ensure that is the case if the one query is anonymous.

@frankleonrose
Copy link
Contributor Author

Good point. I was thinking of the spec in isolation rather than globally.

leebyron added a commit that referenced this pull request Mar 22, 2016
Fix formal spec of lone anonymous operation
@leebyron leebyron merged commit 3b08851 into graphql:master Mar 22, 2016
@leebyron
Copy link
Collaborator

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants