-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add Appendix C - Specified Type System Definitions #1037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
martinbonnin
wants to merge
8
commits into
graphql:main
Choose a base branch
from
martinbonnin:builtin-sdl
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
02670fc
Add appendix C - builtin definitions
martinbonnin d397d1a
also run prettier
martinbonnin ee90eb8
update graphql-js
martinbonnin 36bb5d6
Update scripts/update-appendix-c.mjs
martinbonnin 275bf54
add specified scalars
martinbonnin 370cfaa
manual tweaking
martinbonnin dcc22ec
built-in => specified
martinbonnin d05591b
another instance of BuiltIn => Specified
martinbonnin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
import { writeFile } from 'node:fs/promises'; | ||
import { printIntrospectionSchema, buildSchema, specifiedScalarTypes, printType } from 'graphql'; | ||
|
||
const FILE = './spec/Appendix C -- Specified Definitions.md'; | ||
function printSpecifiedScalars() { | ||
return specifiedScalarTypes | ||
.map((type) => printType(type)) | ||
.join('\n\n'); | ||
} | ||
|
||
const introspectionSchema = printIntrospectionSchema(buildSchema(`type Query { i: Int }`)); | ||
const prefix = ` | ||
# C. Appendix: Type System Definitions | ||
|
||
This appendix lists the specified type system definitions. | ||
|
||
The descriptions are non-normative. Implementations are recommended to use them | ||
for consistency but different descriptions are allowed. | ||
|
||
The order of types, fields, arguments, values and directives is non-normative. | ||
|
||
\`\`\`graphql | ||
` | ||
|
||
const suffix = ` | ||
\`\`\` | ||
` | ||
await writeFile(FILE, prefix + printSpecifiedScalars() + '\n\n' + introspectionSchema + suffix); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.