Skip to content

language support for NullValue #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Nov 1, 2016
Merged

language support for NullValue #544

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
c1ca9a8
language support for NullValue
langpavel Oct 27, 2016
24d3de2
support null literal in Printer
langpavel Oct 27, 2016
48a463d
astFromValue returns NullValue for explicit null
langpavel Oct 27, 2016
c5a24f3
astFromNode does not converts NonNull values to NullValue
langpavel Oct 28, 2016
61385b7
astFromValue correctly handles NonNull values
langpavel Oct 28, 2016
9a571ef
test: astFromValue converts input objects with explicit nulls
langpavel Oct 28, 2016
8261a4d
handle null values in valueFromAST
langpavel Oct 28, 2016
588dd43
Support null in schemaPrinter
langpavel Oct 28, 2016
e60b785
isValidLiteralValue: check for NullValue in NonNull type
langpavel Oct 28, 2016
f2c3c20
Add nullish in kitchen sink test
langpavel Oct 28, 2016
b1339cf
isValidLiteralValue: Accept null in if nullable type + tests
langpavel Oct 31, 2016
1c29b5d
Tests for default null values
langpavel Oct 31, 2016
07ac6d7
ArgumentsOfCorrectType - valid null into list
langpavel Oct 31, 2016
2a28c0c
comment
langpavel Oct 31, 2016
6b61bb6
isNullish is unnecessary there
langpavel Oct 31, 2016
bf83f7f
a note about difference between undefined and null
langpavel Oct 31, 2016
5a3585f
one test for null is enough
langpavel Oct 31, 2016
2823bd3
be consistent in return
langpavel Oct 31, 2016
8ffbfef
ArgumentsOfCorrectType tests from null values
langpavel Nov 1, 2016
d5e104f
Update valueFromAST.js
leebyron Nov 1, 2016
4803be7
Update valueFromAST.js
leebyron Nov 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add nullish in kitchen sink test
  • Loading branch information
@langpavel
langpavel committed Oct 28, 2016
commit f2c3c2085e97113fe1fcdff1994da4ec1a7da9ec
2 changes: 1 addition & 1 deletion src/language/__tests__/kitchen-sink.graphql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,6 @@ fragment frag on Friend {
}

{
unnamed(truthy: true, falsey: false),
unnamed(truthy: true, falsey: false, nullish: null),
query
}
2 changes: 1 addition & 1 deletion src/language/__tests__/printer-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ fragment frag on Friend {
}

{
unnamed(truthy: true, falsey: false)
unnamed(truthy: true, falsey: false, nullish: null)
query
}
`);
Expand Down
6 changes: 6 additions & 0 deletions src/language/__tests__/visitor-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -614,6 +614,12 @@ describe('Visitor', () => {
[ 'enter', 'BooleanValue', 'value', 'Argument' ],
[ 'leave', 'BooleanValue', 'value', 'Argument' ],
[ 'leave', 'Argument', 1, undefined ],
[ 'enter', 'Argument', 2, undefined ],
[ 'enter', 'Name', 'name', 'Argument' ],
[ 'leave', 'Name', 'name', 'Argument' ],
[ 'enter', 'NullValue', 'value', 'Argument' ],
[ 'leave', 'NullValue', 'value', 'Argument' ],
[ 'leave', 'Argument', 2, undefined ],
[ 'leave', 'Field', 0, undefined ],
[ 'enter', 'Field', 1, undefined ],
[ 'enter', 'Name', 'name', 'Field' ],
Expand Down