Skip to content

docs: add guide on directives #4401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 27, 2025
Merged

docs: add guide on directives #4401

merged 4 commits into from
May 27, 2025

Conversation

sarahxsanders
Copy link
Contributor

Adds guide "Using Directives in GraphQL.js"

@sarahxsanders sarahxsanders marked this pull request as ready for review May 20, 2025 00:02
@sarahxsanders sarahxsanders requested a review from a team as a code owner May 20, 2025 00:02
JoviDeCroock
JoviDeCroock approved these changes May 20, 2025
View reviewed changes
@sarahxsanders
Copy link
Contributor Author

Resolved that feedback, thank you @JoviDeCroock!!

@JoviDeCroock JoviDeCroock merged commit 1f1d89d into graphql:16.x.x May 27, 2025
20 checks passed
@benjie benjie mentioned this pull request May 29, 2025
Merged
benjie
benjie reviewed May 29, 2025
View reviewed changes
Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent docs; the only thing I felt was missing was that we should advise users not to use directives where field arguments could be used instead. I've raised this advice as #4417

benjie added a commit that referenced this pull request May 29, 2025
@benjie
Indicate that field arguments should always be preferred over directi…
90aaadc 
…ves (#4417)

Follow up to #4401
yaacovCR pushed a commit to yaacovCR/graphql-js that referenced this pull request May 30, 2025
@sarahxsanders @yaacovCR
docs: add guide on directives (graphql#4401)
a850f0e 
Adds guide "Using Directives in GraphQL.js"
yaacovCR pushed a commit that referenced this pull request May 30, 2025
@sarahxsanders @yaacovCR
docs: add guide on directives (#4401)
043d098 
Adds guide "Using Directives in GraphQL.js"
yaacovCR pushed a commit to yaacovCR/graphql-js that referenced this pull request May 30, 2025
@benjie @yaacovCR
Indicate that field arguments should always be preferred over directi…
0bfba7c 
…ves (graphql#4417)

Follow up to graphql#4401
yaacovCR pushed a commit that referenced this pull request May 30, 2025
@benjie @yaacovCR
Indicate that field arguments should always be preferred over directi…
c431fc0 
…ves (#4417)

Follow up to #4401
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjie benjie benjie left review comments

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Assignees
No one assigned
Labels
PR: docs 📝
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sarahxsanders @benjie @JoviDeCroock