Commits on Jul 10, 2024

1. fix(incremental): pass through errors from return functions that throw …

   Early execution may result in non-completed streams after publishing is completed -- these streams must be closed using their return methods. When this occurs, we should pass through any error that occurs in the clean-up function instead of swallowing errors.
   
   Swallowing errors is a bad practice that could lead to memory leaks. The argument in favor of swallowing the error might be that because the stream was "executed early" and the error does not impact any of the returned data, there is no "place" to forward the error.
   
   But there is a way to forward the error, and that's on the next() call that returns { value: undefined, done: true } to end the stream. We will therefore appropriately send all the data and be able to pass through an error. Servers processing our stream should be made aware of this behavior and put in place error handling procedures that allow them to forward the data to clients when they see a payload with { hasNext: false } and then filter any further errors from clients. Servers could also postpone sending { hasNext: false } until the clean-up has been performed, and then optionally send information about the error in the extensions key, if that made sense. It would be up to the server!

   

   yaacovCR committed Jul 10, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for d6377eb
   • Browse repository at this point

   Copy the full SHA

   d6377eb View commit details

   Browse the repository at this point in the history