Fix typing for isNonNullType
#3597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
= If a type is a non-null type, then the wrapped type must be nullable. = Introduces `GraphQLNullableInputType` and `GraphQLNullableOutputType` to properly represent the result when `isNonNullType` is called on parameters of type `GraphQLInputType` or `GraphQLOutputType`.
👷 Deploy request for compassionate-pike-271cb3 pending review.Visit the deploys page to approve it
|
|
Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
yaacovCR
changed the title
isNonNullTypeisNonNullType
yaacovCR
added
PR: bug fix 🐞
yaacovCR
changed the title
isNonNullTypeisNonNullType
|
My guess is that this qualifies as a "bug fix" and can go into a patch release. |
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
May 19, 2022
Motivation: 1. Makes it easier to understand the type hierarchy. 2. Adding a new type, were it ever to happen, would require fewer code changes. Depends on graphql#3597
Yes, but the patch releases don't make sense in alpha :) |
IvanGoncharov
approved these changes
May 19, 2022
yaacovCR
added
PR: feature 🚀
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
May 19, 2022
Motivation: 1. Makes it easier to understand the type hierarchy. 2. Adding a new type, were it ever to happen, would require fewer code changes. Depends on graphql#3597
yaacovCR
added a commit
that referenced
this pull request
May 19, 2022
Motivation: 1. Makes it easier to understand the type hierarchy. 2. Adding a new type, were it ever to happen, would require fewer code changes. Depends on #3597
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
May 31, 2022
GraphQLNonNull wrapper can only be applies to nullable types related: graphql#3597 see also: graphql#3617 (comment)
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Jun 1, 2022
GraphQLNonNull wrapper can only be applies to nullable types related: graphql#3597 see also: graphql#3617 (comment)
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Jun 1, 2022
`GraphQLNonNull<GraphQLNullableType>` This is related to graphql#3597, in the sense that graphql#3597 made the `GraphQLNonNull<GraphQL*Type>` => `GraphQLNonNull<GraphQLNullable*Type>` change in other code points related to the `isNonNullType` function, but not within `GraphQLWrappingType` or assertNonNullType. This PR was prompted by the uncovering of a bug by a different PR, see: graphql#3617 (comment)
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Jun 2, 2022
`GraphQLNonNull<GraphQLNullableType>` This is related to graphql#3597, in the sense that graphql#3597 made the `GraphQLNonNull<GraphQL*Type>` => `GraphQLNonNull<GraphQLNullable*Type>` change in other code points related to the `isNonNullType` function, but not within `GraphQLWrappingType` or assertNonNullType. This PR was prompted by the uncovering of a bug by a different PR, see: graphql#3617 (comment)
IvanGoncharov
pushed a commit
that referenced
this pull request
Jun 6, 2022
) `GraphQLNonNull<GraphQLNullableType>` This is related to #3597, in the sense that #3597 made the `GraphQLNonNull<GraphQL*Type>` => `GraphQLNonNull<GraphQLNullable*Type>` change in other code points related to the `isNonNullType` function, but not within `GraphQLWrappingType` or assertNonNullType. This PR was prompted by the uncovering of a bug by a different PR, see: #3617 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
= If a type is a non-null type, then the wrapped type must be nullable.
= Introduces
GraphQLNullableInputTypeandGraphQLNullableOutputTypeto properly represent the result whenisNonNullTypeis called on parameters of typeGraphQLInputTypeorGraphQLOutputType.