-
Notifications
You must be signed in to change notification settings - Fork 2k
[RFC] Client Controlled Nullability experiment implementation w/o execution #3418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updates: I've merged in the list syntax, rebased on |
The latest changes of this PR are available on NPM as Also you can depend on latest version built from this PR: |
The latest changes of this PR are available on NPM as Also you can depend on latest version built from this PR: |
New behavior was selected for null propagation at the last WG meeting, there are going to be some pretty major changes incoming. We're sticking with the current list syntax. |
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@IvanGoncharov Alright I've moved over the code that Apollo-iOS needs, as we discussed. Thanks again! |
9ee621a
to
bb68261
Compare
… w/o execution (graphql#3418)" This reverts commit 699ec58.
… w/o execution (graphql#3418)" This reverts commit 699ec58.
… w/o execution (graphql#3418)" This reverts commit 699ec58. We're winding down work on CCN in favor of True Schema Nullability. More context: graphql/nullability-wg#37
This branch is a subset of #3281 with a new flag introduced to mark the new operators experimental so they can be merged into master.
To set up the experiment gates, inspiration was drawn from #1141
For additional context see #3281 (comment)
State of the experiment:
We're merging in two parts of the original RFC and holding off on some of the more controversial bits that are still heavily in flux.
This PR only introduces parsing, lexing, printing, and visiting for the
?
and!
operators and list syntax. It does not include validation or execution.