Skip to content

[RFC] Client Controlled Nullability experiment implementation w/o execution #3418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Jun 28, 2022

Conversation

twof
Copy link
Contributor

@twof twof commented Dec 8, 2021

This branch is a subset of #3281 with a new flag introduced to mark the new operators experimental so they can be merged into master.

To set up the experiment gates, inspiration was drawn from #1141

For additional context see #3281 (comment)

State of the experiment:

We're merging in two parts of the original RFC and holding off on some of the more controversial bits that are still heavily in flux.

This PR only introduces parsing, lexing, printing, and visiting for the ? and ! operators and list syntax. It does not include validation or execution.

@twof twof requested a review from IvanGoncharov December 15, 2021 01:14
@IvanGoncharov IvanGoncharov added spec RFC Implementation of a proposed change to the GraphQL specification PR: feature 🚀 requires increase of "minor" version number labels Dec 22, 2021
@twof
Copy link
Contributor Author

twof commented Dec 22, 2021

Updates: I've merged in the list syntax, rebased on main, and I've got all tests passing. @IvanGoncharov let me know if there's anything I can do to help with the experiment flag implementation.

@github-actions
Copy link

The latest changes of this PR are available on NPM as
graphql@16.3.0-canary.pr.3418.64c65ba6a2e7e923ed9a476c945f3c72da7a6c7f
Note: no gurantees provided so please use your own discretion.

Also you can depend on latest version built from this PR:
npm install --save graphql@canary-pr-3418

@github-actions
Copy link

The latest changes of this PR are available on NPM as
graphql@16.3.0-canary.pr.3418.662180be9091ee1edf699b4cf4922bd5b7705297
Note: no gurantees provided so please use your own discretion.

Also you can depend on latest version built from this PR:
npm install --save graphql@canary-pr-3418

@twof
Copy link
Contributor Author

twof commented Mar 6, 2022

New behavior was selected for null propagation at the last WG meeting, there are going to be some pretty major changes incoming. We're sticking with the current list syntax.

@twof twof changed the title [RFC] Client Controlled Nullability experiment implementation [RFC] Client Controlled Nullability experiment implementation w/o execution Mar 6, 2022
@twof
Copy link
Contributor Author

twof commented Apr 11, 2022

@saihaj are you or the other folks on the review team going to have time to take a look at it this week? If so, I can rebase on main and make sure it's up to date with the other branch with execution: #3510

@netlify
Copy link

netlify bot commented Apr 27, 2022

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 904a368
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/629d7b0cfd7684000965302b
😎 Deploy Preview https://deploy-preview-3418--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@twof
Copy link
Contributor Author

twof commented Apr 27, 2022

@IvanGoncharov Alright I've moved over the code that Apollo-iOS needs, as we discussed. Thanks again!

@twof twof force-pushed the CCNExperiment branch from c5b76d3 to 8debdbc Compare June 6, 2022 02:47
@twof twof requested a review from IvanGoncharov June 8, 2022 03:36
@IvanGoncharov IvanGoncharov merged commit 699ec58 into graphql:main Jun 28, 2022
@twof twof mentioned this pull request Jul 4, 2022
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Sep 26, 2024
yaacovCR added a commit to yaacovCR/graphql-js that referenced this pull request Sep 26, 2024
yaacovCR pushed a commit to twof/graphql-js that referenced this pull request Sep 26, 2024
… w/o execution (graphql#3418)"

This reverts commit 699ec58.

We're winding down work on CCN in favor of True Schema Nullability.

More context: graphql/nullability-wg#37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: feature 🚀 requires increase of "minor" version number spec RFC Implementation of a proposed change to the GraphQL specification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants