Sync execution TS definitions with Flow. #2106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically: Create jsutils/Path.d.ts and pull some utility funcs out to there Add typeResolver options
JacksonKearl
pushed a commit
to JacksonKearl/graphql-js
that referenced
this pull request
Aug 23, 2019
Specifically: Add `extensions` field in lots of places Reorder fields Both this and graphql#2106 add Path.d.ts, but they're the same. If theres a merge conflict, just pick one.
Member
|
@JacksonKearl Excellent work 👍 |
IvanGoncharov
added
the
PR: bug fix 🐞
IvanGoncharov
pushed a commit
that referenced
this pull request
Aug 23, 2019
* Sync type TS definitions with Flow Specifically: Add `extensions` field in lots of places Reorder fields Both this and #2106 add Path.d.ts, but they're the same. If theres a merge conflict, just pick one. * `unknown` => `any`, to target TS@2.6 * Widen `introspectionTypes` type to `GraphQLType[]` * use Maybe<Readonly<Record<...>>> as `extension` type * Remove `ResponsePath` export (now `jsutils/Path`) * More removal of `ResponsePath`
This was referenced Sep 1, 2019
Merged
This was referenced Oct 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically:
Create
tstypes/jsutils/Path.d.tsand pull some utility functions out to there (as is done in the implementation)Add typeResolver options