Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error messages have non-standard capitalization and quote usage #4196

Open
yaacovCR opened this issue Sep 21, 2024 · 0 comments
Open

Error messages have non-standard capitalization and quote usage #4196

yaacovCR opened this issue Sep 21, 2024 · 0 comments

Comments

@yaacovCR
Copy link
Contributor

For example, sometimes we capitalize the types of GraphQL schema elements (e.g. Object type) and sometimes we do not.

Sometimes we quote the type name, field name, etc, and sometimes we do not.

Within #3044 @leebyron removed many quotes => unclear if that's intentional, but seems to look nicer. The rebased version does not make this change, preferring to pull any quotes change out into a separate PR, and hopefully be consistent across the entire code base.

See also: #4195 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant