Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Flow in test files #1484

Closed
IvanGoncharov opened this issue Aug 26, 2018 · 0 comments · Fixed by #1866
Closed

Enable Flow in test files #1484

IvanGoncharov opened this issue Aug 26, 2018 · 0 comments · Fixed by #1866
Labels
enhancement help wanted

Comments

@IvanGoncharov
Copy link
Member

Currently, tests are covering only runtime behavior and not testing Flow types.
So it's very easy to break Flow types for public APIs and have it to pass yarn t, e.g. #1483 (comment)
@IvanGoncharov IvanGoncharov mentioned this issue Sep 23, 2018
Merged
IvanGoncharov added a commit that referenced this issue Sep 26, 2018
@IvanGoncharov
Explicitly annotate (@flow/@noflow) every JS file (#1533)
7874229 
It's the first step towards #1484 and also enables additional ESLint rules.
IvanGoncharov added a commit to IvanGoncharov/graphql-js that referenced this issue May 18, 2019
@IvanGoncharov
Enable Flow in "visitor-test.js"
7867ce8 
Fixes graphql#1484
@IvanGoncharov IvanGoncharov mentioned this issue May 18, 2019
Merged
IvanGoncharov added a commit that referenced this issue May 18, 2019
@IvanGoncharov
Enable Flow in "visitor-test.js" (#1866)
ad2110e 
Fixes #1484
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable Flow in "visitor-test.js" IvanGoncharov/graphql-js
1 participant
@IvanGoncharov