Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: graphql/graphql-js
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: bc32ccd
Choose a base ref
...
head repository: graphql/graphql-js
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3b971c5
Choose a head ref
  • 9 commits
  • 9 files changed
  • 3 contributors

Commits on Jan 24, 2024

  1. docs: reviewer and merge process (#4013)

    In GraphQL.js working group we discussed and put process in place. But
    we never officially wrote down in docs. You can watch this recording
    https://youtu.be/BBxc_HmB71I?si=cvdUMI47vBsT9F2y&t=1316 or check the
    transcript. These are the changes we agreed in the working group, just
    putting them in writing.
    
    ---------
    
    Co-authored-by: Benjie <benjie@jemjie.com>
    saihaj and benjie authored Jan 24, 2024
    Configuration menu
    Copy the full SHA
    9c90a23 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. fix(incremental): skip all empty subsequent results (#3993)

    The publish method checks to see if a subsequent result is empty; this
    same logic should be employed to suppress pending notices for empty
    records.
    
    This has already been achieved for subsequent results that are children
    of the initial result, as we generated the pending notices from the list
    of initially published records.
    
    For subsequent results that are children of other subsequent results, we
    previously generated the pending notice prior to actually publishing.
    
    This change integrates the logic: the publishing method itself returns a
    pending notice as required. This results in a bug-fix for subsequent
    records of other subsequent records as well as a reduction of code for
    subsequent results to the initial result.
    yaacovCR authored Mar 19, 2024
    Configuration menu
    Copy the full SHA
    ef478a2 View commit details
    Browse the repository at this point in the history
  2. allow nested defers at the same level

    if we allow nesting of defers at the same level then we have to handle the case where a defer is completely empty -- not just empty because its fields are also contained within a parent.
    
    this means that collectFields must directly return the new defer usages so that even empty defer usages can be used to create fragments so that we can track their children
    yaacovCR committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    bf20902 View commit details
    Browse the repository at this point in the history
  3. simplify FieldGroup

    yaacovCR committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    9596293 View commit details
    Browse the repository at this point in the history
  4. incremental delivery rewrite

    yaacovCR committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    664758c View commit details
    Browse the repository at this point in the history
  5. re-introduction of simple errorPath based filtering

    removes the need for entire GraphQLResult class and host of helper functions, presumably improving performance in both the non-incremental and incremental cases
    
    this filtering can probably be further improved, as we do not have to check for errors in the path tree higher than the current incremental context's path, if we chose to save that information.
    yaacovCR committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    4cd2361 View commit details
    Browse the repository at this point in the history
  6. refine filtering

    We can stop checking for errors that will "filter" child futures once we have reached the point in the path at which the current incrementalContext was branched.
    yaacovCR committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    da515f5 View commit details
    Browse the repository at this point in the history
  7. try to optimize?

    yaacovCR committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    1e89149 View commit details
    Browse the repository at this point in the history
  8. optimize further

    yaacovCR committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    3b971c5 View commit details
    Browse the repository at this point in the history
Loading