-
Notifications
You must be signed in to change notification settings - Fork 2k
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: graphql/graphql-js
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: bc32ccd
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: graphql/graphql-js
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3b971c5
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 9 commits
- 9 files changed
- 3 contributors
Commits on Jan 24, 2024
-
docs: reviewer and merge process (#4013)
In GraphQL.js working group we discussed and put process in place. But we never officially wrote down in docs. You can watch this recording https://youtu.be/BBxc_HmB71I?si=cvdUMI47vBsT9F2y&t=1316 or check the transcript. These are the changes we agreed in the working group, just putting them in writing. --------- Co-authored-by: Benjie <benjie@jemjie.com>
Configuration menu - View commit details
-
Copy full SHA for 9c90a23 - Browse repository at this point
Copy the full SHA 9c90a23View commit details
Commits on Mar 19, 2024
-
fix(incremental): skip all empty subsequent results (#3993)
The publish method checks to see if a subsequent result is empty; this same logic should be employed to suppress pending notices for empty records. This has already been achieved for subsequent results that are children of the initial result, as we generated the pending notices from the list of initially published records. For subsequent results that are children of other subsequent results, we previously generated the pending notice prior to actually publishing. This change integrates the logic: the publishing method itself returns a pending notice as required. This results in a bug-fix for subsequent records of other subsequent records as well as a reduction of code for subsequent results to the initial result.
Configuration menu - View commit details
-
Copy full SHA for ef478a2 - Browse repository at this point
Copy the full SHA ef478a2View commit details -
allow nested defers at the same level
if we allow nesting of defers at the same level then we have to handle the case where a defer is completely empty -- not just empty because its fields are also contained within a parent. this means that collectFields must directly return the new defer usages so that even empty defer usages can be used to create fragments so that we can track their children
Configuration menu - View commit details
-
Copy full SHA for bf20902 - Browse repository at this point
Copy the full SHA bf20902View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9596293 - Browse repository at this point
Copy the full SHA 9596293View commit details -
Configuration menu - View commit details
-
Copy full SHA for 664758c - Browse repository at this point
Copy the full SHA 664758cView commit details -
re-introduction of simple errorPath based filtering
removes the need for entire GraphQLResult class and host of helper functions, presumably improving performance in both the non-incremental and incremental cases this filtering can probably be further improved, as we do not have to check for errors in the path tree higher than the current incremental context's path, if we chose to save that information.
Configuration menu - View commit details
-
Copy full SHA for 4cd2361 - Browse repository at this point
Copy the full SHA 4cd2361View commit details -
We can stop checking for errors that will "filter" child futures once we have reached the point in the path at which the current incrementalContext was branched.
Configuration menu - View commit details
-
Copy full SHA for da515f5 - Browse repository at this point
Copy the full SHA da515f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e89149 - Browse repository at this point
Copy the full SHA 1e89149View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b971c5 - Browse repository at this point
Copy the full SHA 3b971c5View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff bc32ccd...3b971c5