Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update regression test matrix #3296

Merged
merged 1 commit into from
Jun 26, 2023
Merged

update regression test matrix #3296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/pr-graphql-compat-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ on:
- 'examples'
- '!examples/monaco-graphql-webpack'

# TODO: test matrix?

permissions:
contents: read # to fetch code (actions/checkout)

Expand All @@ -23,7 +21,8 @@ jobs:
runs-on: ubuntu-20.04
strategy:
matrix:
release: ['15.5.3', '^15.8.0', '16.1.0', '16.2.0', '16.3.0']
# test all peer ranges
release: ['^15.5.0', '^15.8.0', 'latest']
Comment on lines +24 to +25
Copy link
Collaborator

@dimaMachina dimaMachina Jun 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we really test 15.5.0? or only 15.8.0 and latest

Copy link
Member Author

@acao acao Jun 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@B2o5T I'm testing the lowest of the peer ranges, in codemirror-graphql we set that as the lowest

steps:
- name: Checkout Code
uses: actions/checkout@v3
Expand Down