-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test scaffolding for vscode-graphql-syntax #3267
Conversation
|
Name | Type |
---|---|
cm6-graphql | Patch |
codemirror-graphql | Patch |
@graphiql/plugin-code-exporter | Patch |
@graphiql/plugin-explorer | Patch |
@graphiql/react | Patch |
graphiql | Patch |
graphql-language-service-cli | Patch |
graphql-language-service-server | Patch |
graphql-language-service | Patch |
monaco-graphql | Patch |
vscode-graphql-execution | Patch |
vscode-graphql-syntax | Patch |
vscode-graphql | Patch |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Ok, immediate problem, prettier autoformatting indents comments, whereas the package doesn't support unit tests unless the line literally starts with #. I'm thinking we need something more manual OR something visual. (at least as well as this) |
@AaronMoat this is awesome! I find it visual enough for our needs. and also, prettier should not be formatting snapshots anyways! just add this to
|
Hi @acao, I was actually talking about the query {
something
# ^ do some assertions here
} But prettier adds two spaces before the I'm tempted to see what this stuff looks by-hand with jest, etc, anyway, I'll have a play and put an alternate PR up (if I get something sensible) |
we shouldn't ignore all plain .graphql files, but if you need them for this, you can set specific ignore rules for these unit tests. this is the only syntax extension so it would make sense. sure, jest sounds nice! @B2o5T wants to move to vitest. I just made it so that jest doesn't need a |
Have put an alternative in #3273 😄 |
Closing in favour of #3273 |
Resolves: #2343
Saw the discussion in #3217 and wanted to revive the older discussion in #2343. Main question - do we think this approach will be helpful, or should we look into something more style/visual based?