Do not clear isFetching state for subscriptions until they complete #2775
Conversation
🦋 Changeset detectedLatest commit: 3f414bd The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
simhnna
force-pushed
the
fix-subscription-fetching-state
branch
from
fc0d949
to
3f414bd
Compare
|
I've added a changeset. Should I also bump graphiql? Previously the spinner only showed until the first result came in. Now it shows until the subscription is completed Here's how it looks now It's better that the play/stop button now shows the correct state. But one could argue that the loading spinner shouldn't be that prominent after the first result is shown. I'm not sure how to best address that, but I'd track that in a separate issue I guess. |
There was a problem hiding this comment.
As described in #2774 (comment), I think we should align on where we wanna go with the UX for subscriptions first before jumping on smaller items and improvements. Blocking this PR for now until we had a discussion about this in the mentioned issue or a new one that tracks this (the code changes would be perfectly fine in itself).
|
Not needed anymore since the same functionality was now implemented in #2907 |
Fixes: #2774