Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade vscode-languageserver #2557

Merged
merged 3 commits into from
Jul 10, 2022
Merged

upgrade vscode-languageserver #2557

merged 3 commits into from
Jul 10, 2022

Conversation

acao
Copy link
Member

@acao acao commented Jul 10, 2022

upgrades the vscode-languageserver and vscode-jsonrpc reference implementations for the lsp server. also upgrades vscode-languageclient in vscode-graphql to 8. seems to work fine for IPC in vscode-graphql at least!

hopefully this solves #2230 once and for all!

@changeset-bot
Copy link

changeset-bot bot commented Jul 10, 2022

🦋 Changeset detected

Latest commit: 9f8cedc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
graphql-language-service-server Minor
graphql-language-service-cli Minor
vscode-graphql Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2022

The latest changes of this PR are available as canary in npm (based on the declared changesets):

graphql-language-service-cli@3.3.0-canary-0ab0e498.0
graphql-language-service-server@2.8.0-canary-0ab0e498.0

@codecov
Copy link

codecov bot commented Jul 10, 2022

Codecov Report

Merging #2557 (9f8cedc) into main (2d91916) will increase coverage by 3.74%.
The diff coverage is 23.12%.

@@            Coverage Diff             @@
##             main    #2557      +/-   ##
==========================================
+ Coverage   65.70%   69.45%   +3.74%     
==========================================
  Files          85       71      -14     
  Lines        5106     4154     -952     
  Branches     1631     1375     -256     
==========================================
- Hits         3355     2885     -470     
+ Misses       1747     1264     -483     
- Partials        4        5       +1     
Impacted Files Coverage Δ
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
packages/codemirror-graphql/src/utils/hintList.ts 95.65% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql-react/src/editor/whitespace.ts 100.00% <ø> (ø)
packages/graphiql-react/src/utility/debounce.ts 0.00% <0.00%> (ø)
packages/graphiql-react/src/editor/tabs.ts 5.76% <5.76%> (ø)
packages/codemirror-graphql/src/variables/lint.ts 46.98% <66.66%> (ø)
packages/codemirror-graphql/src/hint.ts 94.73% <100.00%> (ø)
... and 97 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb1db96...9f8cedc. Read the comment docs.

…mplementations under the hood.

also upgrades `vscode-languageclient` to match. seems to work fine for IPC in `vscode-graphql` at least!

hopefully this solves #2230 once and for all!
@acao acao merged commit 3304606 into main Jul 10, 2022
@acao acao deleted the upgrade-lsp-server branch July 10, 2022 18:33
@acao acao mentioned this pull request Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant