Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release vscode-graphql@0.4.2 from the monorepo #2288

Merged
merged 2 commits into from
Apr 11, 2022
Merged

Conversation

acao
Copy link
Member

@acao acao commented Apr 11, 2022

This permanently fixes #2269

@changeset-bot
Copy link

changeset-bot bot commented Apr 11, 2022

🦋 Changeset detected

Latest commit: ecd444b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
graphql-language-service Patch
graphql-language-service-server Patch
vscode-graphql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #2288 (ecd444b) into main (2d91916) will decrease coverage by 0.98%.
The diff coverage is 73.92%.

@@            Coverage Diff             @@
##             main    #2288      +/-   ##
==========================================
- Coverage   65.70%   64.72%   -0.99%     
==========================================
  Files          85       81       -4     
  Lines        5106     5315     +209     
  Branches     1631     1701      +70     
==========================================
+ Hits         3355     3440      +85     
- Misses       1747     1871     +124     
  Partials        4        4              
Impacted Files Coverage Δ
packages/codemirror-graphql/src/hint.ts 94.73% <ø> (ø)
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
...kages/codemirror-graphql/src/utils/forEachState.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/utils/hintList.ts 95.65% <ø> (ø)
...ackages/codemirror-graphql/src/utils/info-addon.ts 1.02% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/hint.ts 89.70% <ø> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql/src/utility/fillLeafs.ts 5.33% <ø> (ø)
... and 74 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c26eea...ecd444b. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 11, 2022

The latest changes of this PR are not available as canary, since there are no linked changesets for this PR.

@acao acao changed the title release vscode-graphql@4.0.2 from the monorepo release vscode-graphql@0.4.2 from the monorepo Apr 11, 2022
@acao
Copy link
Member Author

acao commented Apr 11, 2022

This stackblitz confirms that removing graphql-config from graphql-language-service does not break the graphiql typescript build, even with skipLibCheck disabled

@acao acao merged commit 07273c3 into main Apr 11, 2022
@acao acao deleted the release-vscode-graphql branch April 11, 2022 13:03
@github-actions github-actions bot mentioned this pull request Apr 11, 2022
acao added a commit that referenced this pull request Apr 11, 2022
- fix esbuild bundling issues with vscode-graphql [#2269](#2269) by fixing esbuild version
- remove `graphql-language-service` dependency on `graphql-config`, which is only for types
- remove direct `vscode-graphql` dependency on `graphql-config`, which previously existed for op exec client
- resolve `graphql-config` to `4.3.0` in `graphql-language-server`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with bundling undici in esbuild on upgrade to vscode 1.66
1 participant