Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP on config change bug fixes for #2230 #2271

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Conversation

acao
Copy link
Member

@acao acao commented Apr 2, 2022

this might be impacting more than just vim users! #2230

we were making some assumptions about vscode default config that were not helpful to non-vscode users of the server (CLI users for example)

@changeset-bot
Copy link

changeset-bot bot commented Apr 2, 2022

🦋 Changeset detected

Latest commit: 0887234

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
graphql-language-service-server Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Apr 2, 2022

Codecov Report

Merging #2271 (0887234) into main (2d91916) will decrease coverage by 0.98%.
The diff coverage is 73.97%.

@@            Coverage Diff             @@
##             main    #2271      +/-   ##
==========================================
- Coverage   65.70%   64.72%   -0.99%     
==========================================
  Files          85       81       -4     
  Lines        5106     5315     +209     
  Branches     1631     1716      +85     
==========================================
+ Hits         3355     3440      +85     
- Misses       1747     1871     +124     
  Partials        4        4              
Impacted Files Coverage Δ
packages/codemirror-graphql/src/hint.ts 94.73% <ø> (ø)
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
...kages/codemirror-graphql/src/utils/forEachState.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/utils/hintList.ts 95.65% <ø> (ø)
...ackages/codemirror-graphql/src/utils/info-addon.ts 1.02% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/hint.ts 89.70% <ø> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql/src/utility/fillLeafs.ts 5.33% <ø> (ø)
... and 73 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e793f88...0887234. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2022

The latest changes of this PR are available as canary in npm (based on the declared changesets):

graphql-language-service-cli@3.2.19-canary-c9d291ea.0
graphql-language-service-server@2.7.18-canary-c9d291ea.0

@acao acao changed the title LSP on config change bug fixes for #2260 LSP on config change bug fixes for #2270 Apr 2, 2022
@acao acao changed the title LSP on config change bug fixes for #2270 LSP on config change bug fixes for #2230 Apr 3, 2022
@acao acao merged commit e15d1da into main Apr 7, 2022
@acao acao deleted the config-handler-bugfix branch April 7, 2022 07:11
@github-actions github-actions bot mentioned this pull request Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant