-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix Windows fileUri to resolve type definition #2214
Conversation
🦋 Changeset detectedLatest commit: ef12543 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Brilliant, thank you! This will be a welcome bugfix for windows users can you add a changeset for the server as per the comment? The CLI will automatically patch increment |
Codecov Report
@@ Coverage Diff @@
## main #2214 +/- ##
==========================================
- Coverage 65.70% 64.85% -0.85%
==========================================
Files 85 77 -8
Lines 5106 5196 +90
Branches 1631 1658 +27
==========================================
+ Hits 3355 3370 +15
- Misses 1747 1822 +75
Partials 4 4
Continue to review full report at Codecov.
|
ad705c3
to
ef12543
Compare
@acao I hope this does the trick :) |
Looking great! i just have one tweak to add, can you give me permissions to write to your branch? |
I will add in another commit |
Fixes #2212
Use
URI.file
instead ofURI.parse
to convert fs path to fileUriI found in some places there's the variable
filePath: Uri
which is a bit confusing because type says it's an Uri, but variable name says it's a path.