Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(variable editor): limit height of editor #2188

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

Shayshoon
Copy link
Contributor

@Shayshoon Shayshoon commented Feb 21, 2022

Added max height 100% to editor bar component

Relevant issue: #2074

added max height 100% to editor bar component
@changeset-bot
Copy link

changeset-bot bot commented Feb 21, 2022

⚠️ No Changeset found

Latest commit: b960a59

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 21, 2022

CLA Signed

The committers are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #2188 (b960a59) into main (2d91916) will decrease coverage by 0.85%.
The diff coverage is 77.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2188      +/-   ##
==========================================
- Coverage   65.70%   64.85%   -0.86%     
==========================================
  Files          85       77       -8     
  Lines        5106     5195      +89     
  Branches     1631     1658      +27     
==========================================
+ Hits         3355     3369      +14     
- Misses       1747     1822      +75     
  Partials        4        4              
Impacted Files Coverage Δ
packages/codemirror-graphql/src/hint.ts 94.73% <ø> (ø)
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
...kages/codemirror-graphql/src/utils/forEachState.ts 100.00% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/hint.ts 89.70% <ø> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql/src/components/QueryEditor.tsx 63.96% <ø> (ø)
packages/graphiql/src/utility/fillLeafs.ts 5.33% <ø> (ø)
...kages/graphiql/src/utility/introspectionQueries.ts 100.00% <ø> (ø)
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9b4cec...b960a59. Read the comment docs.

@Shayshoon Shayshoon marked this pull request as ready for review February 22, 2022 21:07
@acao
Copy link
Member

acao commented Feb 24, 2022

thank you @Shayshoon !

@acao acao merged commit d3e0005 into graphql:main Feb 24, 2022
@Shayshoon
Copy link
Contributor Author

My pleasure!

@Shayshoon Shayshoon deleted the variable-editor-infinite-height branch February 24, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants