Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use temporary fork of picomatch based on browser support PR #2101

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

acao
Copy link
Member

@acao acao commented Dec 7, 2021

This PR:
micromatch/picomatch#73

introduces browser support for picomatch

I created a temporary npm package as a fork of picomatch that includes the changes in this PR

picomatch works fine with CRA and other common webpack configs, but not so well with vite and some other bunders.

I can confirm that this fixes the issue in vite:

https://stackblitz.com/edit/vitejs-vite-nsepqi?file=src%2Fmain.tsx

@changeset-bot
Copy link

changeset-bot bot commented Dec 7, 2021

🦋 Changeset detected

Latest commit: 12f477c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
graphql-language-service Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #2101 (12f477c) into main (2d91916) will decrease coverage by 2.37%.
The diff coverage is 66.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2101      +/-   ##
==========================================
- Coverage   65.70%   63.33%   -2.38%     
==========================================
  Files          85       79       -6     
  Lines        5106     5280     +174     
  Branches     1631     1666      +35     
==========================================
- Hits         3355     3344      -11     
- Misses       1747     1932     +185     
  Partials        4        4              
Impacted Files Coverage Δ
packages/codemirror-graphql/src/hint.ts 94.73% <ø> (ø)
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
...kages/codemirror-graphql/src/utils/forEachState.ts 100.00% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/hint.ts 89.70% <ø> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql/src/components/QueryEditor.tsx 63.96% <ø> (ø)
packages/graphiql/src/utility/fillLeafs.ts 5.33% <ø> (ø)
...kages/graphiql/src/utility/introspectionQueries.ts 100.00% <ø> (ø)
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a36cba9...12f477c. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2021

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2021

@github-actions github-actions bot temporarily deployed to monaco-graphql-webpack-preview December 7, 2021 20:08 Inactive
@github-actions github-actions bot temporarily deployed to graphiql-webpack-preview December 7, 2021 20:08 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2021

@github-actions github-actions bot temporarily deployed to graphiql-cdn-preview December 7, 2021 20:08 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2021

The latest changes of this PR are available as canary in npm (based on the declared changesets):

codemirror-graphql@1.2.9-canary-5edec51e.0
graphiql@1.5.14-canary-5edec51e.0
graphql-language-service@4.1.2-canary-5edec51e.0
graphql-language-service-cli@3.2.11-canary-5edec51e.0
graphql-language-service-server@2.7.11-canary-5edec51e.0
monaco-graphql@1.0.4-canary-5edec51e.0

@github-actions github-actions bot temporarily deployed to graphiql-webpack-preview December 7, 2021 20:26 Inactive
@github-actions github-actions bot temporarily deployed to monaco-graphql-webpack-preview December 7, 2021 20:26 Inactive
@github-actions github-actions bot temporarily deployed to graphiql-cdn-preview December 7, 2021 20:27 Inactive
@acao acao merged commit e20760f into main Dec 7, 2021
@acao acao deleted the fix/picomatch-fork branch December 7, 2021 20:27
@github-actions github-actions bot mentioned this pull request Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant