Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: graphql 15 fixes, feature flags, tests #2091

Merged
merged 1 commit into from
Dec 6, 2021
Merged

fix: graphql 15 fixes, feature flags, tests #2091

merged 1 commit into from
Dec 6, 2021

Conversation

acao
Copy link
Member

@acao acao commented Dec 6, 2021

  • fix graphql 15 related issues in several packages
  • introduce build, test & cypress run against graphql@15
  • use version driven logic to make tests pass

I think this will fix a longstanding issue, especially glaring with the graphql@16 upgrade, is ensuring legacy support, and even setting the path for an eventual test matrix of graphql versions if we want

without deploy previews it doesn't feel exhaustive, but this is a good first step

@changeset-bot
Copy link

changeset-bot bot commented Dec 6, 2021

🦋 Changeset detected

Latest commit: 3b6a150

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
codemirror-graphql Patch
graphiql Patch
graphql-language-service-interface Patch
graphql-language-service-server Patch
graphql-language-service-utils Patch
graphql-language-service-types Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2021

The latest changes of this PR are available as canary in npm (based on the declared changesets):

codemirror-graphql@1.2.8-canary-07e866d1.0
graphiql@1.5.12-canary-07e866d1.0
graphql-language-service@4.1.1-canary-07e866d1.0
graphql-language-service-cli@3.2.10-canary-07e866d1.0
graphql-language-service-interface@2.10.1-canary-07e866d1.0
graphql-language-service-parser@1.10.4-canary-07e866d1.0
graphql-language-service-server@2.7.10-canary-07e866d1.0
graphql-language-service-types@1.8.7-canary-07e866d1.0
graphql-language-service-utils@2.7.1-canary-07e866d1.0
monaco-graphql@1.0.2-canary-07e866d1.0

@acao acao force-pushed the fix/graphql-15 branch 2 times, most recently from 2051769 to ba12e41 Compare December 6, 2021 16:57
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2021

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2021

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2021

@github-actions github-actions bot temporarily deployed to graphiql-webpack-preview December 6, 2021 17:07 Inactive
@github-actions github-actions bot temporarily deployed to monaco-graphql-webpack-preview December 6, 2021 17:07 Inactive
@github-actions github-actions bot temporarily deployed to graphiql-cdn-preview December 6, 2021 17:08 Inactive
@github-actions github-actions bot temporarily deployed to monaco-graphql-webpack-preview December 6, 2021 17:13 Inactive
@github-actions github-actions bot temporarily deployed to graphiql-webpack-preview December 6, 2021 17:13 Inactive
@github-actions github-actions bot temporarily deployed to graphiql-cdn-preview December 6, 2021 17:14 Inactive
@codecov
Copy link

codecov bot commented Dec 6, 2021

Codecov Report

Merging #2091 (e5a0de3) into main (2d91916) will decrease coverage by 2.38%.
The diff coverage is 65.98%.

❗ Current head e5a0de3 differs from pull request most recent head 3b6a150. Consider uploading reports for the commit 3b6a150 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2091      +/-   ##
==========================================
- Coverage   65.70%   63.32%   -2.39%     
==========================================
  Files          85       79       -6     
  Lines        5106     5279     +173     
  Branches     1631     1665      +34     
==========================================
- Hits         3355     3343      -12     
- Misses       1747     1932     +185     
  Partials        4        4              
Impacted Files Coverage Δ
packages/codemirror-graphql/src/hint.ts 94.73% <ø> (ø)
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
...kages/codemirror-graphql/src/utils/forEachState.ts 100.00% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/hint.ts 89.70% <ø> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql/src/components/QueryEditor.tsx 63.96% <ø> (ø)
packages/graphiql/src/utility/fillLeafs.ts 5.33% <ø> (ø)
...kages/graphiql/src/utility/introspectionQueries.ts 100.00% <ø> (ø)
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 848da58...3b6a150. Read the comment docs.

@github-actions github-actions bot temporarily deployed to graphiql-webpack-preview December 6, 2021 17:26 Inactive
@github-actions github-actions bot temporarily deployed to graphiql-cdn-preview December 6, 2021 17:26 Inactive
@github-actions github-actions bot temporarily deployed to monaco-graphql-webpack-preview December 6, 2021 17:27 Inactive
@github-actions github-actions bot temporarily deployed to graphiql-webpack-preview December 6, 2021 17:42 Inactive
@github-actions github-actions bot temporarily deployed to graphiql-cdn-preview December 6, 2021 17:42 Inactive
@github-actions github-actions bot temporarily deployed to monaco-graphql-webpack-preview December 6, 2021 17:45 Inactive
@github-actions github-actions bot temporarily deployed to graphiql-cdn-preview December 6, 2021 17:45 Inactive
@github-actions github-actions bot temporarily deployed to graphiql-webpack-preview December 6, 2021 17:45 Inactive
@acao acao force-pushed the fix/graphql-15 branch 3 times, most recently from 6b536c2 to e5a0de3 Compare December 6, 2021 17:50
@github-actions github-actions bot temporarily deployed to graphiql-cdn-preview December 6, 2021 17:53 Inactive
@github-actions github-actions bot temporarily deployed to graphiql-webpack-preview December 6, 2021 17:53 Inactive
@github-actions github-actions bot temporarily deployed to monaco-graphql-webpack-preview December 6, 2021 17:53 Inactive
@github-actions github-actions bot temporarily deployed to graphiql-webpack-preview December 6, 2021 18:06 Inactive
@github-actions github-actions bot temporarily deployed to monaco-graphql-webpack-preview December 6, 2021 18:06 Inactive
@github-actions github-actions bot temporarily deployed to graphiql-cdn-preview December 6, 2021 18:07 Inactive
- fix graphql 15 related issues in several packages
- introduce build & tests against graphql@15
- use version driven logic to make tests pass
@github-actions github-actions bot temporarily deployed to graphiql-webpack-preview December 6, 2021 18:13 Inactive
@github-actions github-actions bot temporarily deployed to graphiql-cdn-preview December 6, 2021 18:13 Inactive
@github-actions github-actions bot temporarily deployed to monaco-graphql-webpack-preview December 6, 2021 18:14 Inactive
@acao acao merged commit ff9cebe into main Dec 6, 2021
@acao acao deleted the fix/graphql-15 branch December 6, 2021 18:15
@github-actions github-actions bot mentioned this pull request Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant