-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: a few major bugs with SDL and remote schema in the language server #2055
Conversation
🦋 Changeset detectedLatest commit: 746f8de The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest changes of this PR are available as canary in npm (based on the declared
|
this fixes the URI scheme related bugs and make sure config works sdl first should work again `fileURLToPath` had been introduced by a contributor and it broke sdl first dev experience. i only tested with remote schemas before releasing my bad! definitions, autocomplete, diagnostics, etc should work again also hides the more verbose logging output for now still the cache miss error will get that next
Codecov Report
@@ Coverage Diff @@
## main #2055 +/- ##
==========================================
- Coverage 65.70% 63.34% -2.37%
==========================================
Files 85 94 +9
Lines 5106 5442 +336
Branches 1631 1715 +84
==========================================
+ Hits 3355 3447 +92
- Misses 1747 1990 +243
- Partials 4 5 +1
Continue to review full report at Codecov.
|
this fixes the URI scheme related bugs and make sure config works
sdl first dev experience should work again
fileURLToPath
had been introduced by a contributor and I didnt test properly, it broke sdl file loading!i only tested with remote schemas before releasing my bad!
definitions, autocomplete, diagnostics, etc should work again
also hides the more verbose logging output for now
still the cache miss error will get that next
This should fix:
#2021 #2018 #1672 #1977
and many others issues
vscode-graphql
repository